2021-02-24 08:42:11

by Jiapeng Chong

Subject: [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static

Fix the following sparse warning:

kernel/rcu/tree_plugin.h:1497:5: warning: symbol
'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static?

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
kernel/rcu/tree_plugin.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 2d60377..8ff8cf8 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -1494,7 +1494,7 @@ static int __init parse_rcu_nocb_poll(char *arg)
* After all, the main point of bypassing is to avoid lock contention
* on ->nocb_lock, which only can happen at high call_rcu() rates.
*/
-int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
+static int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
module_param(nocb_nobypass_lim_per_jiffy, int, 0);

/*
--
1.8.3.1

2021-02-25 04:57:36

by Paul E. McKenney

Subject: Re: [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static

On Wed, Feb 24, 2021 at 04:30:29PM +0800, Jiapeng Chong wrote:
> Fix the following sparse warning:
>
> kernel/rcu/tree_plugin.h:1497:5: warning: symbol
> 'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Queued with Frederic's ack (given offlist), thank you both!

Thanx, Paul

> ---
> kernel/rcu/tree_plugin.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 2d60377..8ff8cf8 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1494,7 +1494,7 @@ static int __init parse_rcu_nocb_poll(char *arg)
> * After all, the main point of bypassing is to avoid lock contention
> * on ->nocb_lock, which only can happen at high call_rcu() rates.
> */
> -int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> +static int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> module_param(nocb_nobypass_lim_per_jiffy, int, 0);
>
> /*
> --
> 1.8.3.1
>