2021-03-24 10:27:27

by yekai (A)

Subject: [PATCH] uacce: fixup coding style

delete invalid and redundant variable initialization.

Signed-off-by: Kai Ye <[email protected]>
Reviewed-by: Zhou Wang <[email protected]>
---
drivers/misc/uacce/uacce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index d07af4e..94843e0 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -126,7 +126,7 @@ static int uacce_fops_open(struct inode *inode, struct file *filep)
{
struct uacce_device *uacce;
struct uacce_queue *q;
- int ret = 0;
+ int ret;

uacce = xa_load(&uacce_xa, iminor(inode));
if (!uacce)
--
2.8.1

2021-03-25 01:57:35

by Greg Kroah-Hartman

Subject: Re: [PATCH] uacce: fixup coding style

On Wed, Mar 24, 2021 at 04:11:55PM +0800, Kai Ye wrote:
> delete invalid and redundant variable initialization.

Why is it "invalid"? Seems to just not be needed.

And this isn't a coding style issue, your subject line is incorrect :(

thanks,

greg k-h