2021-03-29 01:58:38

by Huang Guobin

Subject: [PATCH net-next v2] net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()

From: Guobin Huang <[email protected]>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Guobin Huang <[email protected]>
---
drivers/net/dsa/ocelot/felix_vsc9959.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 5ff623ee76a6..789fe08cae50 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -1057,10 +1057,8 @@ static int vsc9959_mdio_bus_alloc(struct ocelot *ocelot)
res.end += felix->imdio_base;

imdio_regs = devm_ioremap_resource(dev, &res);
- if (IS_ERR(imdio_regs)) {
- dev_err(dev, "failed to map internal MDIO registers\n");
+ if (IS_ERR(imdio_regs))
return PTR_ERR(imdio_regs);
- }

hw = enetc_hw_alloc(dev, imdio_regs);
if (IS_ERR(hw)) {

2021-03-29 20:24:52

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next v2] net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 29 Mar 2021 09:54:05 +0800 you wrote:
> From: Guobin Huang <[email protected]>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Guobin Huang <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next,v2] net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()
https://git.kernel.org/netdev/net-next/c/a180be79db4a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html