2021-04-25 10:44:25

by Jiapeng Chong

Subject: [PATCH] of: overlay: Remove redundant assignment to ret

Variable ret is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/of/overlay.c:1197:2: warning: Value stored to 'ret' is never
read [clang-analyzer-deadcode.DeadStores].

drivers/of/overlay.c:1026:2: warning: Value stored to 'ret' is never
read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/of/overlay.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 23effe5..74bb5e5 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -1023,7 +1023,6 @@ int of_overlay_fdt_apply(const void *overlay_fdt, u32 overlay_fdt_size,
struct device_node *overlay_root = NULL;

*ovcs_id = 0;
- ret = 0;

if (overlay_fdt_size < sizeof(struct fdt_header) ||
fdt_check_header(overlay_fdt)) {
@@ -1194,8 +1193,6 @@ int of_overlay_remove(int *ovcs_id)
struct overlay_changeset *ovcs;
int ret, ret_apply, ret_tmp;

- ret = 0;
-
if (devicetree_corrupt()) {
pr_err("suspect devicetree state, refuse to remove overlay\n");
ret = -EBUSY;
--
1.8.3.1

2021-05-03 18:59:43

by Rob Herring (Arm)

Subject: Re: [PATCH] of: overlay: Remove redundant assignment to ret

On Sun, 25 Apr 2021 18:40:58 +0800, Jiapeng Chong wrote:
> Variable ret is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> drivers/of/overlay.c:1197:2: warning: Value stored to 'ret' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> drivers/of/overlay.c:1026:2: warning: Value stored to 'ret' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/of/overlay.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Applied, thanks!