2021-04-27 10:27:03

by Jiapeng Chong

Subject: [PATCH] rds: Remove redundant assignment to nr_sig

Variable nr_sig is being assigned a value however the assignment is
never read, so this redundant assignment can be removed.

Cleans up the following clang-analyzer warning:

net/rds/ib_send.c:297:2: warning: Value stored to 'nr_sig' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/rds/ib_send.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index 92b4a86..4190b90 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -294,7 +294,6 @@ void rds_ib_send_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc)

rds_ib_ring_free(&ic->i_send_ring, completed);
rds_ib_sub_signaled(ic, nr_sig);
- nr_sig = 0;

if (test_and_clear_bit(RDS_LL_SEND_FULL, &conn->c_flags) ||
test_bit(0, &conn->c_map_queued))
--
1.8.3.1

2021-04-27 21:26:52

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] rds: Remove redundant assignment to nr_sig

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 27 Apr 2021 18:24:47 +0800 you wrote:
> Variable nr_sig is being assigned a value however the assignment is
> never read, so this redundant assignment can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/rds/ib_send.c:297:2: warning: Value stored to 'nr_sig' is never read
> [clang-analyzer-deadcode.DeadStores].
>
> [...]

Here is the summary with links:
- rds: Remove redundant assignment to nr_sig
https://git.kernel.org/netdev/net-next/c/4db6187d721e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html