2021-04-27 10:36:40

by Jiapeng Chong

Subject: [PATCH] net/tls: Remove redundant initialization of record

record is being initialized to ctx->open_record but this is never
read as record is overwritten later on. Remove the redundant
initialization.

Cleans up the following clang-analyzer warning:

net/tls/tls_device.c:421:26: warning: Value stored to 'record' during
its initialization is never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/tls/tls_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
index d9cd229..72227fe 100644
--- a/net/tls/tls_device.c
+++ b/net/tls/tls_device.c
@@ -418,7 +418,7 @@ static int tls_push_data(struct sock *sk,
struct tls_context *tls_ctx = tls_get_ctx(sk);
struct tls_prot_info *prot = &tls_ctx->prot_info;
struct tls_offload_context_tx *ctx = tls_offload_ctx_tx(tls_ctx);
- struct tls_record_info *record = ctx->open_record;
+ struct tls_record_info *record;
int tls_push_record_flags;
struct page_frag *pfrag;
size_t orig_size = size;
--
1.8.3.1

2021-04-27 21:24:12

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/tls: Remove redundant initialization of record

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 27 Apr 2021 18:28:22 +0800 you wrote:
> record is being initialized to ctx->open_record but this is never
> read as record is overwritten later on. Remove the redundant
> initialization.
>
> Cleans up the following clang-analyzer warning:
>
> net/tls/tls_device.c:421:26: warning: Value stored to 'record' during
> its initialization is never read [clang-analyzer-deadcode.DeadStores].
>
> [...]

Here is the summary with links:
- net/tls: Remove redundant initialization of record
https://git.kernel.org/netdev/net-next/c/3afef8c7aa2d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html