2021-05-06 11:05:16

by Jiapeng Chong

Subject: [PATCH] dmaengine: idxd: Remove redundant variable cdev_ctx

Variable cdev_ctx is set to '&ictx[wq->idxd->data->type]' but this
value is not used, hence it is a redundant assignment and can be
removed.

Clean up the following clang-analyzer warning:

drivers/dma/idxd/cdev.c:300:2: warning: Value stored to 'cdev_ctx' is
never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/dma/idxd/cdev.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index 302cba5..6c72089 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c
@@ -295,9 +295,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
void idxd_wq_del_cdev(struct idxd_wq *wq)
{
struct idxd_cdev *idxd_cdev;
- struct idxd_cdev_context *cdev_ctx;

- cdev_ctx = &ictx[wq->idxd->data->type];
idxd_cdev = wq->idxd_cdev;
wq->idxd_cdev = NULL;
cdev_device_del(&idxd_cdev->cdev, &idxd_cdev->dev);
--
1.8.3.1

2021-05-06 15:09:44

by Dave Jiang

Subject: Re: [PATCH] dmaengine: idxd: Remove redundant variable cdev_ctx

On 5/6/2021 4:00 AM, Jiapeng Chong wrote:
> Variable cdev_ctx is set to '&ictx[wq->idxd->data->type]' but this
> value is not used, hence it is a redundant assignment and can be
> removed.
>
> Clean up the following clang-analyzer warning:
>
> drivers/dma/idxd/cdev.c:300:2: warning: Value stored to 'cdev_ctx' is
> never read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: Dave Jiang <[email protected]>

Thanks.


> ---
> drivers/dma/idxd/cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
> index 302cba5..6c72089 100644
> --- a/drivers/dma/idxd/cdev.c
> +++ b/drivers/dma/idxd/cdev.c
> @@ -295,9 +295,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq)
> void idxd_wq_del_cdev(struct idxd_wq *wq)
> {
> struct idxd_cdev *idxd_cdev;
> - struct idxd_cdev_context *cdev_ctx;
>
> - cdev_ctx = &ictx[wq->idxd->data->type];
> idxd_cdev = wq->idxd_cdev;
> wq->idxd_cdev = NULL;
> cdev_device_del(&idxd_cdev->cdev, &idxd_cdev->dev);

2021-05-10 14:41:18

by Vinod Koul

Subject: Re: [PATCH] dmaengine: idxd: Remove redundant variable cdev_ctx

On 06-05-21, 19:00, Jiapeng Chong wrote:
> Variable cdev_ctx is set to '&ictx[wq->idxd->data->type]' but this
> value is not used, hence it is a redundant assignment and can be
> removed.
>
> Clean up the following clang-analyzer warning:
>
> drivers/dma/idxd/cdev.c:300:2: warning: Value stored to 'cdev_ctx' is
> never read [clang-analyzer-deadcode.DeadStores].

Applied, thanks

--
~Vinod