2021-05-08 03:54:30

by Jinmeng Zhou

Subject: [PATCH] net/nfc/rawsock.c: fix a permission check bug

From: Jeimon <[email protected]>

The function rawsock_create() calls a privileged function sk_alloc(), which requires a ns-aware check to check net->user_ns, i.e., ns_capable(). However, the original code checks the init_user_ns using capable(). So we replace the capable() with ns_capable().

Signed-off-by: Jeimon <[email protected]>
---
net/nfc/rawsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c
index 955c195ae..a76b62f55 100644
--- a/net/nfc/rawsock.c
+++ b/net/nfc/rawsock.c
@@ -329,7 +329,7 @@ static int rawsock_create(struct net *net, struct socket *sock,
return -ESOCKTNOSUPPORT;

if (sock->type == SOCK_RAW) {
- if (!capable(CAP_NET_RAW))
+ if (!ns_capable(net->user_ns, CAP_NET_RAW))
return -EPERM;
sock->ops = &rawsock_raw_ops;
} else {
--
2.17.1

2021-05-10 21:31:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/nfc/rawsock.c: fix a permission check bug

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 8 May 2021 11:52:30 +0800 you wrote:
> From: Jeimon <[email protected]>
>
> The function rawsock_create() calls a privileged function sk_alloc(), which requires a ns-aware check to check net->user_ns, i.e., ns_capable(). However, the original code checks the init_user_ns using capable(). So we replace the capable() with ns_capable().
>
> Signed-off-by: Jeimon <[email protected]>
> ---
> net/nfc/rawsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net/nfc/rawsock.c: fix a permission check bug
https://git.kernel.org/netdev/net/c/8ab78863e9ef

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html