2021-05-20 07:33:35

by Jerome Brunet

Subject: [PATCH] clk: meson: axg-audio: improve deferral handling

Use dev_err_probe() for clock and reset resources to indicate the deferral
reason through sysfs when waiting for the resource to come up.

Signed-off-by: Jerome Brunet <[email protected]>
---
This is a follow up on
https://lore.kernel.org/r/[email protected]

drivers/clk/meson/axg-audio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
index 7c8d02164443..bfe36bd41339 100644
--- a/drivers/clk/meson/axg-audio.c
+++ b/drivers/clk/meson/axg-audio.c
@@ -1665,8 +1665,7 @@ static int devm_clk_get_enable(struct device *dev, char *id)
clk = devm_clk_get(dev, id);
if (IS_ERR(clk)) {
ret = PTR_ERR(clk);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "failed to get %s", id);
+ dev_err_probe(dev, ret, "failed to get %s", id);
return ret;
}

@@ -1811,7 +1810,7 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)

ret = device_reset(dev);
if (ret) {
- dev_err(dev, "failed to reset device\n");
+ dev_err_probe(dev, ret, "failed to reset device\n");
return ret;
}

--
2.31.1

2021-05-21 19:39:02

by Martin Blumenstingl

Subject: Re: [PATCH] clk: meson: axg-audio: improve deferral handling

On Thu, May 20, 2021 at 9:32 AM Jerome Brunet <[email protected]> wrote:
>
> Use dev_err_probe() for clock and reset resources to indicate the deferral
> reason through sysfs when waiting for the resource to come up.
>
> Signed-off-by: Jerome Brunet <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

2021-05-24 09:40:38

by Jerome Brunet

Subject: Re: [PATCH] clk: meson: axg-audio: improve deferral handling

On Thu 20 May 2021 at 22:18, Martin Blumenstingl <[email protected]> wrote:

> On Thu, May 20, 2021 at 9:32 AM Jerome Brunet <[email protected]> wrote:
>>
>> Use dev_err_probe() for clock and reset resources to indicate the deferral
>> reason through sysfs when waiting for the resource to come up.
>>
>> Signed-off-by: Jerome Brunet <[email protected]>
> Reviewed-by: Martin Blumenstingl <[email protected]>

Applied

2021-05-26 03:15:36

by Stephen Boyd

Subject: Re: [PATCH] clk: meson: axg-audio: improve deferral handling

Quoting Jerome Brunet (2021-05-20 00:31:36)
> Use dev_err_probe() for clock and reset resources to indicate the deferral
> reason through sysfs when waiting for the resource to come up.
>
> Signed-off-by: Jerome Brunet <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>