2021-05-10 14:32:47

by Andy Shevchenko

Subject: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK

Use SPI_MODE_X_MASK instead of open coded variant.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
index 5703e8313980..2635c80231bb 100644
--- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
+++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
@@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi *spifi,
ctrl |= SPIFI_CTRL_DUAL;
}

- switch (mode & (SPI_CPHA | SPI_CPOL)) {
+ switch (mode & SPI_MODE_X_MASK) {
case SPI_MODE_0:
ctrl &= ~SPIFI_CTRL_MODE3;
break;
--
2.30.2

2021-05-10 20:24:20

by Michael Walle

Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK

Am 2021-05-10 16:13, schrieb Andy Shevchenko:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/mtd/spi-nor/controllers/nxp-spifi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> index 5703e8313980..2635c80231bb 100644
> --- a/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> +++ b/drivers/mtd/spi-nor/controllers/nxp-spifi.c
> @@ -326,7 +326,7 @@ static int nxp_spifi_setup_flash(struct nxp_spifi
> *spifi,
> ctrl |= SPIFI_CTRL_DUAL;
> }
>
> - switch (mode & (SPI_CPHA | SPI_CPOL)) {
> + switch (mode & SPI_MODE_X_MASK) {
> case SPI_MODE_0:
> ctrl &= ~SPIFI_CTRL_MODE3;
> break;

Reviewed-by: Michael Walle <[email protected]>

-michael

2021-05-27 14:09:45

by Vignesh Raghavendra

Subject: Re: [PATCH v1 1/1] mtd: spi-nor: Use SPI_MODE_X_MASK

On Mon, 10 May 2021 17:13:43 +0300, Andy Shevchenko wrote:
> Use SPI_MODE_X_MASK instead of open coded variant.

Updated $subject to:
"mtd: spi-nor: nxp-spifi: Use SPI_MODE_X_MASK"

Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: Use SPI_MODE_X_MASK
https://git.kernel.org/mtd/c/5c26d52c9e

--
Regards
Vignesh