2021-05-11 09:42:51

by Pratyush Yadav

Subject: [PATCH] mtd: spi-nor: Add documentation for spi_nor_soft_reset()

Document what the function does and that it should only be used when it
is known that the device supports it. This will avoid unaware
programmers thinking that they can arbitrarily use it to reset the
device.

Suggested-by: Michael Walle <[email protected]>
Signed-off-by: Pratyush Yadav <[email protected]>

---

drivers/mtd/spi-nor/core.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 265d8b25fc7f..59e207f2e0e3 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -2988,6 +2988,21 @@ static int spi_nor_init(struct spi_nor *nor)
return 0;
}

+/**
+ * spi_nor_soft_reset() - Perform a software reset
+ * @nor: pointer to 'struct spi_nor'
+ *
+ * Performs a "Soft Reset and Enter Default Protocol Mode" sequence which resets
+ * the device to its power-on-reset state. This is useful when the software has
+ * made some changes to device (volatile) registers and needs to reset it before
+ * shutting down, for example.
+ *
+ * Not every flash supports this sequence. The same set of opcodes might be used
+ * for some other operation on a flash that does not support this. Support for
+ * this sequence can be discovered via SFDP in the BFPT table.
+ *
+ * Return: 0 on success, -errno otherwise.
+ */
static void spi_nor_soft_reset(struct spi_nor *nor)
{
struct spi_mem_op op;
--
2.30.0

2021-05-21 19:36:22

by Michael Walle

Subject: Re: [PATCH] mtd: spi-nor: Add documentation for spi_nor_soft_reset()

Am 2021-05-11 11:39, schrieb Pratyush Yadav:
> Document what the function does and that it should only be used when it
> is known that the device supports it. This will avoid unaware
> programmers thinking that they can arbitrarily use it to reset the
> device.
>
> Suggested-by: Michael Walle <[email protected]>
> Signed-off-by: Pratyush Yadav <[email protected]>

Reviewed-by: Michael Walle <[email protected]>

2021-05-27 14:10:15

by Vignesh Raghavendra

Subject: Re: [PATCH] mtd: spi-nor: Add documentation for spi_nor_soft_reset()

On Tue, 11 May 2021 15:09:58 +0530, Pratyush Yadav wrote:
> Document what the function does and that it should only be used when it
> is known that the device supports it. This will avoid unaware
> programmers thinking that they can arbitrarily use it to reset the
> device.

Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: Add documentation for spi_nor_soft_reset()
https://git.kernel.org/mtd/c/ccfb7cf18f

--
Regards
Vignesh