2021-06-01 11:08:38

by Jiapeng Chong

Subject: [PATCH] ethernet: myri10ge: Fix missing error code in myri10ge_probe()

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'status'.

Eliminate the follow smatch warning:

drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe()
warn: missing error code 'status'.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index c84c8bf..fc99ad8 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -3815,6 +3815,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
dev_err(&pdev->dev,
"invalid sram_size %dB or board span %ldB\n",
mgp->sram_size, mgp->board_span);
+ status = -EINVAL;
goto abort_with_ioremap;
}
memcpy_fromio(mgp->eeprom_strings,
--
1.8.3.1

2021-06-01 23:01:23

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] ethernet: myri10ge: Fix missing error code in myri10ge_probe()

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 1 Jun 2021 19:04:51 +0800 you wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'status'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe()
> warn: missing error code 'status'.
>
> [...]

Here is the summary with links:
- ethernet: myri10ge: Fix missing error code in myri10ge_probe()
https://git.kernel.org/netdev/net/c/f336d0b93ae9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html