2021-06-02 10:19:51

by Jiapeng Chong

Subject: [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.

Eliminate the follow smatch warning:

net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
net/core/rtnetlink.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 714d5fa..3e84279 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4842,8 +4842,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
if (err < 0)
goto errout;

- if (!skb->len)
+ if (!skb->len) {
+ err = -EINVAL;
goto errout;
+ }

rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
return 0;
--
1.8.3.1

2021-06-03 21:02:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] rtnetlink: Fix missing error code in rtnl_bridge_notify()

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 2 Jun 2021 18:15:04 +0800 you wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'err'.
>
> Eliminate the follow smatch warning:
>
> net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
> 'err'.
>
> [...]

Here is the summary with links:
- rtnetlink: Fix missing error code in rtnl_bridge_notify()
https://git.kernel.org/netdev/net/c/a8db57c1d285

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html