2021-06-02 09:50:31

by Yang Yingliang

[permalink] [raw]
Subject: [PATCH -next] i3c: master: svc: fix doc warning in svc-i3c-master.c

Fix the following make W=1 warning:

drivers/i3c/master/svc-i3c-master.c:207: warning: expecting prototype for struct svc_i3c_i3c_dev_data. Prototype was for struct svc_i3c_i2c_dev_data instead

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/i3c/master/svc-i3c-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index eeb49b5d90ef..879e5a64acaf 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -195,7 +195,7 @@ struct svc_i3c_master {
};

/**
- * struct svc_i3c_i3c_dev_data - Device specific data
+ * struct svc_i3c_i2c_dev_data - Device specific data
* @index: Index in the master tables corresponding to this device
* @ibi: IBI slot index in the master structure
* @ibi_pool: IBI pool associated to this device
--
2.25.1


2021-06-07 06:25:39

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH -next] i3c: master: svc: fix doc warning in svc-i3c-master.c

Hi Yang,

Yang Yingliang <[email protected]> wrote on Wed, 2 Jun 2021
16:55:44 +0800:

> Fix the following make W=1 warning:
>
> drivers/i3c/master/svc-i3c-master.c:207: warning: expecting prototype for struct svc_i3c_i3c_dev_data. Prototype was for struct svc_i3c_i2c_dev_data instead
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/i3c/master/svc-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index eeb49b5d90ef..879e5a64acaf 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -195,7 +195,7 @@ struct svc_i3c_master {
> };
>
> /**
> - * struct svc_i3c_i3c_dev_data - Device specific data
> + * struct svc_i3c_i2c_dev_data - Device specific data
> * @index: Index in the master tables corresponding to this device
> * @ibi: IBI slot index in the master structure
> * @ibi_pool: IBI pool associated to this device


Reviewed-by: Miquel Raynal <[email protected]>


Thanks,
Miquèl

2021-06-09 16:58:32

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH -next] i3c: master: svc: fix doc warning in svc-i3c-master.c

On Wed, 2 Jun 2021 16:55:44 +0800, Yang Yingliang wrote:
> Fix the following make W=1 warning:
>
> drivers/i3c/master/svc-i3c-master.c:207: warning: expecting prototype for struct svc_i3c_i3c_dev_data. Prototype was for struct svc_i3c_i2c_dev_data instead

Applied, thanks!

[1/1] i3c: master: svc: fix doc warning in svc-i3c-master.c
commit: 3e5feb11a82945c88a1518fd2682ca8de66c37d3

Best regards,
--
Alexandre Belloni <[email protected]>