2021-06-19 20:35:56

by Alex Bee

Subject: [PATCH] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc

Re-add the regulator-always-on property for vcc_sdio which supplies sdmmc,
since it gets disabled during reboot now and the bootrom expects it to be
enabled when booting from SD card. This makes rebooting impossible in that
case and requires a hard reset to boot again.

Fixes: 04a0077fdb19 ("arm64: dts: rockchip: Remove always-on properties from regulator nodes on rk3399-roc-pc.")
Signed-off-by: Alex Bee <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
index c172f5a803e7..da3021dc0ff3 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi
@@ -389,6 +389,7 @@ regulator-state-mem {

vcc_sdio: LDO_REG4 {
regulator-name = "vcc_sdio";
+ regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3000000>;
--
2.27.0

2021-06-19 22:03:52

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc

On Sat, 19 Jun 2021 14:13:06 +0200, Alex Bee wrote:
> Re-add the regulator-always-on property for vcc_sdio which supplies sdmmc,
> since it gets disabled during reboot now and the bootrom expects it to be
> enabled when booting from SD card. This makes rebooting impossible in that
> case and requires a hard reset to boot again.

Applied, thanks!

[1/1] arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc
commit: eb607cd4957fb0ef97beb2a8293478be6a54240a

Best regards,
--
Heiko Stuebner <[email protected]>