2021-07-01 19:58:08

by Bhaumik Bhatt

Subject: [PATCH] bus: mhi: core: Use mhi_soc_reset() API instead of register write

Currently, register writes are used when ramdump collection in
panic path occurs. Replace that with new mhi_soc_reset() API such
that a controller defined reset() function is exercised if one is
present and the regular SOC reset is done if it is not.

Signed-off-by: Bhaumik Bhatt <[email protected]>
---
drivers/bus/mhi/core/boot.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
index 8100cf5..10a91df 100644
--- a/drivers/bus/mhi/core/boot.c
+++ b/drivers/bus/mhi/core/boot.c
@@ -112,9 +112,7 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
/* Hardware reset so force device to enter RDDM */
dev_dbg(dev,
"Did not enter RDDM, do a host req reset\n");
- mhi_write_reg(mhi_cntrl, mhi_cntrl->regs,
- MHI_SOC_RESET_REQ_OFFSET,
- MHI_SOC_RESET_REQ);
+ mhi_soc_reset(mhi_cntrl);
udelay(delayus);
}

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-07-01 21:02:49

by Hemant Kumar

Subject: Re: [PATCH] bus: mhi: core: Use mhi_soc_reset() API instead of register write

On Thu, 2021-07-01 at 12:55 -0700, Bhaumik Bhatt wrote:
> Currently, register writes are used when ramdump collection in
> panic path occurs. Replace that with new mhi_soc_reset() API such
> that a controller defined reset() function is exercised if one is
> present and the regular SOC reset is done if it is not.
>
> Signed-off-by: Bhaumik Bhatt <[email protected]>
> ---
Reviewed-by: Hemant Kumar <[email protected]>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project