2021-07-20 13:08:54

by Colin King

Subject: [PATCH] net: marvell: clean up trigraph warning on ??! string

From: Colin Ian King <[email protected]>

The character sequence ??! is a trigraph and causes the following
clang warning:

drivers/net/ethernet/marvell/mvneta.c:2604:39: warning: trigraph ignored [-Wtrigraphs]

Clean this by replacing it with single ?.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 76a7777c746d..fc4dbcc58f5f 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -2666,7 +2666,7 @@ static int mvneta_tx_tso(struct sk_buff *skb, struct net_device *dev,
return 0;

if (skb_headlen(skb) < (skb_transport_offset(skb) + tcp_hdrlen(skb))) {
- pr_info("*** Is this even possible???!?!?\n");
+ pr_info("*** Is this even possible?\n");
return 0;
}

--
2.31.1

2021-07-20 14:56:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: marvell: clean up trigraph warning on ??! string

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 20 Jul 2021 14:03:11 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> The character sequence ??! is a trigraph and causes the following
> clang warning:
>
> drivers/net/ethernet/marvell/mvneta.c:2604:39: warning: trigraph ignored [-Wtrigraphs]
>
> [...]

Here is the summary with links:
- net: marvell: clean up trigraph warning on ??! string
https://git.kernel.org/netdev/net-next/c/fa660684e531

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html