2021-08-20 15:46:57

by Maksim Kiselev

[permalink] [raw]
Subject: [PATCH] net: marvell: fix MVNETA_TX_IN_PRGRS bit number

According to Armada XP datasheet bit at 0 position is corresponding for
TxInProg indication.

Signed-off-by: Maxim Kiselev <[email protected]>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 76a7777c746da..de32e5b49053b 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -105,7 +105,7 @@
#define MVNETA_VLAN_PRIO_TO_RXQ 0x2440
#define MVNETA_VLAN_PRIO_RXQ_MAP(prio, rxq) ((rxq) << ((prio) * 3))
#define MVNETA_PORT_STATUS 0x2444
-#define MVNETA_TX_IN_PRGRS BIT(1)
+#define MVNETA_TX_IN_PRGRS BIT(0)
#define MVNETA_TX_FIFO_EMPTY BIT(8)
#define MVNETA_RX_MIN_FRAME_SIZE 0x247c
/* Only exists on Armada XP and Armada 370 */
--
2.30.2


2021-08-20 22:11:30

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net: marvell: fix MVNETA_TX_IN_PRGRS bit number

On Fri, 20 Aug 2021 18:39:51 +0300 Maxim Kiselev wrote:
> According to Armada XP datasheet bit at 0 position is corresponding for
> TxInProg indication.
>
> Signed-off-by: Maxim Kiselev <[email protected]>

Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit")

?

2021-08-23 12:02:16

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: marvell: fix MVNETA_TX_IN_PRGRS bit number

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 20 Aug 2021 18:39:51 +0300 you wrote:
> According to Armada XP datasheet bit at 0 position is corresponding for
> TxInProg indication.
>
> Signed-off-by: Maxim Kiselev <[email protected]>
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- net: marvell: fix MVNETA_TX_IN_PRGRS bit number
https://git.kernel.org/netdev/net/c/359f4cdd7d78

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html