2021-09-06 07:24:52

by zhaoxiao

Subject: [PATCH] stmmac: dwmac-loongson:Fix missing return value

Add the return value when phy_mode < 0.

Signed-off-by: zhaoxiao <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..ecf759ee1c9f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -109,8 +109,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
plat->bus_id = pci_dev_id(pdev);

phy_mode = device_get_phy_mode(&pdev->dev);
- if (phy_mode < 0)
+ if (phy_mode < 0) {
dev_err(&pdev->dev, "phy_mode not found\n");
+ return phy_mode;
+ }

plat->phy_interface = phy_mode;
plat->interface = PHY_INTERFACE_MODE_GMII;
--
2.20.1

2021-09-06 12:31:10

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] stmmac: dwmac-loongson:Fix missing return value

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 6 Sep 2021 15:21:07 +0800 you wrote:
> Add the return value when phy_mode < 0.
>
> Signed-off-by: zhaoxiao <[email protected]>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Here is the summary with links:
- stmmac: dwmac-loongson:Fix missing return value
https://git.kernel.org/netdev/net/c/5289de5929d1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html