2022-07-18 02:05:59

by Yang Li

Subject: [PATCH -next] ublk_drv: remove unneeded semicolon

Eliminate the following coccicheck warnings:
./drivers/block/ublk_drv.c:1467:2-3: Unneeded semicolon
./drivers/block/ublk_drv.c:1528:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/block/ublk_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 52fd0af8a4f2..b005cb1354e4 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -1464,7 +1464,7 @@ static int ublk_ctrl_cmd_validate(struct io_uring_cmd *cmd,
return -EINVAL;
if (!header->addr)
return -EINVAL;
- };
+ }

return 0;
}
@@ -1525,7 +1525,7 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd *cmd,
break;
default:
break;
- };
+ }
out:
io_uring_cmd_done(cmd, ret, 0);
pr_devel("%s: cmd done ret %d cmd_op %x, dev id %d qid %d\n",
--
2.20.1.7.g153144c

2022-07-18 08:09:16

by Ming Lei

Subject: Re: [PATCH -next] ublk_drv: remove unneeded semicolon

On Mon, Jul 18, 2022 at 09:54:31AM +0800, Yang Li wrote:
> Eliminate the following coccicheck warnings:
> ./drivers/block/ublk_drv.c:1467:2-3: Unneeded semicolon
> ./drivers/block/ublk_drv.c:1528:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Reviewed-by: Ming Lei <[email protected]>


thanks,
Ming

2022-07-18 19:29:44

by Jens Axboe

Subject: Re: [PATCH -next] ublk_drv: remove unneeded semicolon

On Mon, 18 Jul 2022 09:54:31 +0800, Yang Li wrote:
> Eliminate the following coccicheck warnings:
> ./drivers/block/ublk_drv.c:1467:2-3: Unneeded semicolon
> ./drivers/block/ublk_drv.c:1528:2-3: Unneeded semicolon
>
>

Applied, thanks!

[1/1] ublk_drv: remove unneeded semicolon
commit: 6b1439d203a3c3d7adcf31ba70734eb95f8fa02d

Best regards,
--
Jens Axboe