2022-08-30 18:54:21

by Andy Shevchenko

Subject: [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()

As a preparation to unexport of_gpio_named_count(), convert the
driver to use gpiod_count() instead.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pci/controller/dwc/pcie-kirin.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index 7f67aad71df4..3bde045e20ad 100644
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -366,12 +366,11 @@ static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie,
struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node;
char name[32];
int ret, i;

/* This is an optional property */
- ret = of_gpio_named_count(np, "hisilicon,clken-gpios");
+ ret = gpiod_count(dev, "hisilicon,clken");
if (ret < 0)
return 0;

--
2.35.1

2022-09-02 16:54:47

by Rob Herring (Arm)

Subject: Re: [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()

On Tue, Aug 30, 2022 at 1:33 PM Andy Shevchenko
<[email protected]> wrote:
>
> As a preparation to unexport of_gpio_named_count(), convert the
> driver to use gpiod_count() instead.

I'm always in favor of removing DT APIs.

> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/pci/controller/dwc/pcie-kirin.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Rob Herring <[email protected]>

2022-09-09 09:51:26

by Lorenzo Pieralisi

Subject: Re: [PATCH v1 1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()

On Tue, 30 Aug 2022 21:33:10 +0300, Andy Shevchenko wrote:
> As a preparation to unexport of_gpio_named_count(), convert the
> driver to use gpiod_count() instead.
>
>

Applied to pci/dwc, thanks!

[1/1] PCI: dwc: Replace of_gpio_named_count() by gpiod_count()
https://git.kernel.org/lpieralisi/pci/c/2023f9c9190e

Thanks,
Lorenzo