2022-05-09 08:53:40

by Xiaoyao Li

Subject: Re: [RFC PATCH v6 017/104] KVM: TDX: Add C wrapper functions for SEAMCALLs to the TDX module

On 5/6/2022 2:14 AM, [email protected] wrote:
> diff --git a/arch/x86/virt/vmx/tdx/seamcall.S b/arch/x86/virt/vmx/tdx/seamcall.S
> index 8df7a16f7685..b4fc8182e1cf 100644
> --- a/arch/x86/virt/vmx/tdx/seamcall.S
> +++ b/arch/x86/virt/vmx/tdx/seamcall.S
> @@ -50,3 +50,4 @@ SYM_FUNC_START(__seamcall)
> FRAME_END
> ret
> SYM_FUNC_END(__seamcall)
> +EXPORT_SYMBOL_GPL(__seamcall)

It cannot compile, we need

#include <asm/export.h>

2022-05-09 11:35:47

by Isaku Yamahata

Subject: Re: [RFC PATCH v6 017/104] KVM: TDX: Add C wrapper functions for SEAMCALLs to the TDX module

On Fri, May 06, 2022 at 04:56:52PM +0800,
Xiaoyao Li <[email protected]> wrote:

> On 5/6/2022 2:14 AM, [email protected] wrote:
> > diff --git a/arch/x86/virt/vmx/tdx/seamcall.S b/arch/x86/virt/vmx/tdx/seamcall.S
> > index 8df7a16f7685..b4fc8182e1cf 100644
> > --- a/arch/x86/virt/vmx/tdx/seamcall.S
> > +++ b/arch/x86/virt/vmx/tdx/seamcall.S
> > @@ -50,3 +50,4 @@ SYM_FUNC_START(__seamcall)
> > FRAME_END
> > ret
> > SYM_FUNC_END(__seamcall)
> > +EXPORT_SYMBOL_GPL(__seamcall)
>
> It cannot compile, we need
>
> #include <asm/export.h>

Thanks, will fix it.

--
Isaku Yamahata <[email protected]>