2022-09-22 07:30:29

by Alexandru Tachici

Subject: [net-next] net: ethernet: adi: Fix invalid parent name length

MII_BUS_ID_SIZE is larger than MAX_PHYS_ITEM_ID_LEN
so we use the former here to set the parent port id.

Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
Signed-off-by: Alexandru Tachici <[email protected]>
---
drivers/net/ethernet/adi/adin1110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/adi/adin1110.c
index 4dacb98e7e0a..4f3c372292f3 100644
--- a/drivers/net/ethernet/adi/adin1110.c
+++ b/drivers/net/ethernet/adi/adin1110.c
@@ -1028,7 +1028,7 @@ static int adin1110_port_get_port_parent_id(struct net_device *dev,
struct adin1110_port_priv *port_priv = netdev_priv(dev);
struct adin1110_priv *priv = port_priv->priv;

- ppid->id_len = strnlen(priv->mii_bus_name, MII_BUS_ID_SIZE);
+ ppid->id_len = strnlen(priv->mii_bus_name, MAX_PHYS_ITEM_ID_LEN);
memcpy(ppid->id, priv->mii_bus_name, ppid->id_len);

return 0;
--
2.34.1

2022-09-22 16:31:45

by patchwork-bot+netdevbpf

Subject: Re: [net-next] net: ethernet: adi: Fix invalid parent name length

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 22 Sep 2022 09:30:49 +0300 you wrote:
> MII_BUS_ID_SIZE is larger than MAX_PHYS_ITEM_ID_LEN
> so we use the former here to set the parent port id.
>
> Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
> Signed-off-by: Alexandru Tachici <[email protected]>
> ---
> drivers/net/ethernet/adi/adin1110.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next] net: ethernet: adi: Fix invalid parent name length
https://git.kernel.org/netdev/net-next/c/2b9977470b39

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html