Add the command line options to disable the new features.
smba : Slow Memory Bandwidth Allocation
bmec : Bandwidth Monitor Event Configuration.
Signed-off-by: Babu Moger <[email protected]>
---
Documentation/admin-guide/kernel-parameters.txt | 2 +-
arch/x86/kernel/cpu/resctrl/core.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index a465d5242774..f3f0870144fb 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -5190,7 +5190,7 @@
rdt= [HW,X86,RDT]
Turn on/off individual RDT features. List is:
cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp,
- mba.
+ mba, smba, bmec.
E.g. to turn on cmt and turn off mba use:
rdt=cmt,!mba
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index 4b970e7192e8..e31c98e2fafc 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -659,6 +659,8 @@ enum {
RDT_FLAG_L2_CAT,
RDT_FLAG_L2_CDP,
RDT_FLAG_MBA,
+ RDT_FLAG_SMBA,
+ RDT_FLAG_BMEC,
};
#define RDT_OPT(idx, n, f) \
@@ -682,6 +684,8 @@ static struct rdt_options rdt_options[] __initdata = {
RDT_OPT(RDT_FLAG_L2_CAT, "l2cat", X86_FEATURE_CAT_L2),
RDT_OPT(RDT_FLAG_L2_CDP, "l2cdp", X86_FEATURE_CDP_L2),
RDT_OPT(RDT_FLAG_MBA, "mba", X86_FEATURE_MBA),
+ RDT_OPT(RDT_FLAG_SMBA, "smba", X86_FEATURE_SMBA),
+ RDT_OPT(RDT_FLAG_BMEC, "bmec", X86_FEATURE_BMEC),
};
#define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)
Hi, Babu,
> Add the command line options to disable the new features.
s/disable/disable or enable/
> smba : Slow Memory Bandwidth Allocation
> bmec : Bandwidth Monitor Event Configuration.
>
> Signed-off-by: Babu Moger <[email protected]>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> arch/x86/kernel/cpu/resctrl/core.c | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt
> b/Documentation/admin-guide/kernel-parameters.txt
> index a465d5242774..f3f0870144fb 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5190,7 +5190,7 @@
> rdt= [HW,X86,RDT]
> Turn on/off individual RDT features. List is:
> cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp,
> - mba.
> + mba, smba, bmec.
> E.g. to turn on cmt and turn off mba use:
> rdt=cmt,!mba
>
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c
> b/arch/x86/kernel/cpu/resctrl/core.c
> index 4b970e7192e8..e31c98e2fafc 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -659,6 +659,8 @@ enum {
> RDT_FLAG_L2_CAT,
> RDT_FLAG_L2_CDP,
> RDT_FLAG_MBA,
> + RDT_FLAG_SMBA,
> + RDT_FLAG_BMEC,
> };
>
> #define RDT_OPT(idx, n, f) \
> @@ -682,6 +684,8 @@ static struct rdt_options rdt_options[] __initdata = {
> RDT_OPT(RDT_FLAG_L2_CAT, "l2cat", X86_FEATURE_CAT_L2),
> RDT_OPT(RDT_FLAG_L2_CDP, "l2cdp", X86_FEATURE_CDP_L2),
> RDT_OPT(RDT_FLAG_MBA, "mba", X86_FEATURE_MBA),
> + RDT_OPT(RDT_FLAG_SMBA, "smba", X86_FEATURE_SMBA),
> + RDT_OPT(RDT_FLAG_BMEC, "bmec", X86_FEATURE_BMEC),
> };
> #define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)
>
>
Thanks.
-Fenghua
[AMD Official Use Only - General]
Hi Fenghua,
> -----Original Message-----
> From: Yu, Fenghua <[email protected]>
> Sent: Wednesday, November 23, 2022 12:26 PM
> To: Moger, Babu <[email protected]>; [email protected]; Chatre, Reinette
> <[email protected]>; [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Bae, Chang Seok <[email protected]>;
> [email protected]; [email protected];
> [email protected]; Das1, Sandipan <[email protected]>;
> Luck, Tony <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> Eranian, Stephane <[email protected]>
> Subject: RE: [PATCH v8 04/13] x86/resctrl: Include new features in command
> line options
>
> Hi, Babu,
>
> > Add the command line options to disable the new features.
> s/disable/disable or enable/
Sure.
Thanks
Babu
>
> > smba : Slow Memory Bandwidth Allocation bmec : Bandwidth Monitor Event
> > Configuration.
> >
> > Signed-off-by: Babu Moger <[email protected]>
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 2 +-
> > arch/x86/kernel/cpu/resctrl/core.c | 4 ++++
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt
> > b/Documentation/admin-guide/kernel-parameters.txt
> > index a465d5242774..f3f0870144fb 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -5190,7 +5190,7 @@
> > rdt= [HW,X86,RDT]
> > Turn on/off individual RDT features. List is:
> > cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp,
> > - mba.
> > + mba, smba, bmec.
> > E.g. to turn on cmt and turn off mba use:
> > rdt=cmt,!mba
> >
> > diff --git a/arch/x86/kernel/cpu/resctrl/core.c
> > b/arch/x86/kernel/cpu/resctrl/core.c
> > index 4b970e7192e8..e31c98e2fafc 100644
> > --- a/arch/x86/kernel/cpu/resctrl/core.c
> > +++ b/arch/x86/kernel/cpu/resctrl/core.c
> > @@ -659,6 +659,8 @@ enum {
> > RDT_FLAG_L2_CAT,
> > RDT_FLAG_L2_CDP,
> > RDT_FLAG_MBA,
> > + RDT_FLAG_SMBA,
> > + RDT_FLAG_BMEC,
> > };
> >
> > #define RDT_OPT(idx, n, f) \
> > @@ -682,6 +684,8 @@ static struct rdt_options rdt_options[] __initdata = {
> > RDT_OPT(RDT_FLAG_L2_CAT, "l2cat", X86_FEATURE_CAT_L2),
> > RDT_OPT(RDT_FLAG_L2_CDP, "l2cdp",
> X86_FEATURE_CDP_L2),
> > RDT_OPT(RDT_FLAG_MBA, "mba", X86_FEATURE_MBA),
> > + RDT_OPT(RDT_FLAG_SMBA, "smba", X86_FEATURE_SMBA),
> > + RDT_OPT(RDT_FLAG_BMEC, "bmec", X86_FEATURE_BMEC),
> > };
> > #define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)
> >
> >
> Thanks.
>
> -Fenghua