2022-11-18 10:14:12

by Tiezhu Yang

Subject: [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep"

The latest version of grep claims the egrep is now obsolete so the build
now contains warnings that look like:
egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the related file to use "grep -E" instead.

sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`

Here are the steps to install the latest grep:

wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
tar xf grep-3.8.tar.gz
cd grep-3.8 && ./configure && make
sudo make install
export PATH=/usr/local/bin:$PATH

Signed-off-by: Tiezhu Yang <[email protected]>
---
samples/bpf/test_cgrp2_tc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/bpf/test_cgrp2_tc.sh b/samples/bpf/test_cgrp2_tc.sh
index 12faf58..395573b 100755
--- a/samples/bpf/test_cgrp2_tc.sh
+++ b/samples/bpf/test_cgrp2_tc.sh
@@ -115,7 +115,7 @@ do_exit() {
if [ "$DEBUG" == "yes" ] && [ "$MODE" != 'cleanuponly' ]
then
echo "------ DEBUG ------"
- echo "mount: "; mount | egrep '(cgroup2|bpf)'; echo
+ echo "mount: "; mount | grep -E '(cgroup2|bpf)'; echo
echo "$CGRP2_TC_LEAF: "; ls -l $CGRP2_TC_LEAF; echo
if [ -d "$BPF_FS_TC_SHARE" ]
then
--
2.1.0

2022-11-18 10:41:10

by Jiri Olsa

Subject: Re: [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep"

On Fri, Nov 18, 2022 at 05:50:01PM +0800, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
>
> sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`
>
> Here are the steps to install the latest grep:
>
> wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
> tar xf grep-3.8.tar.gz
> cd grep-3.8 && ./configure && make
> sudo make install
> export PATH=/usr/local/bin:$PATH
>
> Signed-off-by: Tiezhu Yang <[email protected]>

Acked-by: Jiri Olsa <[email protected]>

jirka

> ---
> samples/bpf/test_cgrp2_tc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/bpf/test_cgrp2_tc.sh b/samples/bpf/test_cgrp2_tc.sh
> index 12faf58..395573b 100755
> --- a/samples/bpf/test_cgrp2_tc.sh
> +++ b/samples/bpf/test_cgrp2_tc.sh
> @@ -115,7 +115,7 @@ do_exit() {
> if [ "$DEBUG" == "yes" ] && [ "$MODE" != 'cleanuponly' ]
> then
> echo "------ DEBUG ------"
> - echo "mount: "; mount | egrep '(cgroup2|bpf)'; echo
> + echo "mount: "; mount | grep -E '(cgroup2|bpf)'; echo
> echo "$CGRP2_TC_LEAF: "; ls -l $CGRP2_TC_LEAF; echo
> if [ -d "$BPF_FS_TC_SHARE" ]
> then
> --
> 2.1.0
>

2022-11-19 00:38:13

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] samples: bpf: Use "grep -E" instead of "egrep"

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[email protected]>:

On Fri, 18 Nov 2022 17:50:01 +0800 you wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
>
> sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`
>
> [...]

Here is the summary with links:
- [bpf-next] samples: bpf: Use "grep -E" instead of "egrep"
https://git.kernel.org/bpf/bpf-next/c/ee748cd95e3a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html