2023-01-10 01:51:26

by Gustavo A. R. Silva

Subject: [PATCH][next] RDMA/erdma: Replace zero-length arrays with flexible-array members

Zero-length arrays are deprecated[1] and we are moving towards
adopting C99 flexible-array members instead. So, replace zero-length
arrays, in a couple of structures, with flex-array members.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [2].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/infiniband/hw/erdma/erdma_hw.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h
index ab371fec610c..4c38d99c73f1 100644
--- a/drivers/infiniband/hw/erdma/erdma_hw.h
+++ b/drivers/infiniband/hw/erdma/erdma_hw.h
@@ -397,7 +397,7 @@ struct erdma_write_sqe {

__le32 rsvd;

- struct erdma_sge sgl[0];
+ struct erdma_sge sgl[];
};

struct erdma_send_sqe {
@@ -408,7 +408,7 @@ struct erdma_send_sqe {
};

__le32 length;
- struct erdma_sge sgl[0];
+ struct erdma_sge sgl[];
};

struct erdma_readreq_sqe {
--
2.34.1

2023-01-10 12:05:02

by Cheng Xu

Subject: Re: [PATCH][next] RDMA/erdma: Replace zero-length arrays with flexible-array members

On 1/10/23 9:40 AM, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members instead. So, replace zero-length
> arrays, in a couple of structures, with flex-array members.
>
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/infiniband/hw/erdma/erdma_hw.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Acked-by: Cheng Xu <[email protected]>

Thanks very much,
Cheng Xu


> diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h
> index ab371fec610c..4c38d99c73f1 100644
> --- a/drivers/infiniband/hw/erdma/erdma_hw.h
> +++ b/drivers/infiniband/hw/erdma/erdma_hw.h
> @@ -397,7 +397,7 @@ struct erdma_write_sqe {
>
> __le32 rsvd;
>
> - struct erdma_sge sgl[0];
> + struct erdma_sge sgl[];
> };
>
> struct erdma_send_sqe {
> @@ -408,7 +408,7 @@ struct erdma_send_sqe {
> };
>
> __le32 length;
> - struct erdma_sge sgl[0];
> + struct erdma_sge sgl[];
> };
>
> struct erdma_readreq_sqe {

2023-01-12 23:02:25

by Kees Cook

Subject: Re: [PATCH][next] RDMA/erdma: Replace zero-length arrays with flexible-array members

On Mon, Jan 09, 2023 at 07:40:22PM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members instead. So, replace zero-length
> arrays, in a couple of structures, with flex-array members.
>
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2023-01-15 11:43:47

by Leon Romanovsky

Subject: Re: [PATCH][next] RDMA/erdma: Replace zero-length arrays with flexible-array members

On Mon, 09 Jan 2023 19:40:22 -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members instead. So, replace zero-length
> arrays, in a couple of structures, with flex-array members.
>
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
>
> [...]

Applied, thanks!

[1/1] RDMA/erdma: Replace zero-length arrays with flexible-array members
https://git.kernel.org/rdma/rdma/c/ed73a505480d54

Best regards,
--
Leon Romanovsky <[email protected]>