2023-02-24 13:06:28

by Johan Hovold

Subject: [PATCH] genirq/msi: Drop dead domain name assignment

Since commit d59f6617eef0 ("genirq: Allow fwnode to carry name
information only") an IRQ domain is always given a name during
allocation (e.g. used for the debugfs entry).

Drop the unused fallback name assignment when creating MSI domains.

Signed-off-by: Johan Hovold <[email protected]>
---
kernel/irq/msi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 783a3e6a0b10..10d29bc87eb2 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -830,11 +830,8 @@ static struct irq_domain *__msi_create_irq_domain(struct fwnode_handle *fwnode,
domain = irq_domain_create_hierarchy(parent, flags | IRQ_DOMAIN_FLAG_MSI, 0,
fwnode, &msi_domain_ops, info);

- if (domain) {
- if (!domain->name && info->chip)
- domain->name = info->chip->name;
+ if (domain)
irq_domain_update_bus_token(domain, info->bus_token);
- }

return domain;
}
--
2.39.2

2023-02-24 20:00:34

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/urgent] genirq/msi: Drop dead domain name assignment

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID: ea9a78c3a7a44e36fa690e1cc90dc2a758c8eb9a
Gitweb: https://git.kernel.org/tip/ea9a78c3a7a44e36fa690e1cc90dc2a758c8eb9a
Author: Johan Hovold <[email protected]>
AuthorDate: Fri, 24 Feb 2023 14:05:09 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Fri, 24 Feb 2023 20:54:58 +01:00

genirq/msi: Drop dead domain name assignment

Since commit d59f6617eef0 ("genirq: Allow fwnode to carry name
information only") an IRQ domain is always given a name during
allocation (e.g. used for the debugfs entry).

Drop the unused fallback name assignment when creating MSI domains.

Signed-off-by: Johan Hovold <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
kernel/irq/msi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 13d9649..efd21b7 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -830,11 +830,8 @@ static struct irq_domain *__msi_create_irq_domain(struct fwnode_handle *fwnode,
domain = irq_domain_create_hierarchy(parent, flags | IRQ_DOMAIN_FLAG_MSI, 0,
fwnode, &msi_domain_ops, info);

- if (domain) {
- if (!domain->name && info->chip)
- domain->name = info->chip->name;
+ if (domain)
irq_domain_update_bus_token(domain, info->bus_token);
- }

return domain;
}