2023-04-13 09:48:48

by Lorenz Bauer

Subject: [PATCH bpf-next] selftests/bpf: fix use of uninitialized op_name in log tests

One of the test assertions uses an uninitialized op_name, which leads
to some headscratching if it fails. Use a string constant instead.

Fixes: b1a7a480a112 ("selftests/bpf: Add fixed vs rotating verifier log tests")
Signed-off-by: Lorenz Bauer <[email protected]>
---
tools/testing/selftests/bpf/prog_tests/verifier_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/verifier_log.c b/tools/testing/selftests/bpf/prog_tests/verifier_log.c
index 475092a78deb..8337c6bc5b95 100644
--- a/tools/testing/selftests/bpf/prog_tests/verifier_log.c
+++ b/tools/testing/selftests/bpf/prog_tests/verifier_log.c
@@ -110,7 +110,7 @@ static void verif_log_subtest(const char *name, bool expect_load_error, int log_
}
if (!ASSERT_EQ(strlen(logs.buf), 24, "log_fixed_25"))
goto cleanup;
- if (!ASSERT_STRNEQ(logs.buf, logs.reference, 24, op_name))
+ if (!ASSERT_STRNEQ(logs.buf, logs.reference, 24, "log_fixed_contents_25"))
goto cleanup;
}

--
2.39.2

2023-04-13 12:37:04

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] selftests/bpf: fix use of uninitialized op_name in log tests

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[email protected]>:

On Thu, 13 Apr 2023 10:47:40 +0100 you wrote:
> One of the test assertions uses an uninitialized op_name, which leads
> to some headscratching if it fails. Use a string constant instead.
>
> Fixes: b1a7a480a112 ("selftests/bpf: Add fixed vs rotating verifier log tests")
> Signed-off-by: Lorenz Bauer <[email protected]>
> ---
> tools/testing/selftests/bpf/prog_tests/verifier_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [bpf-next] selftests/bpf: fix use of uninitialized op_name in log tests
https://git.kernel.org/bpf/bpf-next/c/5a674611d116

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html