2023-05-05 09:25:55

by Peng Fan (OSS)

Subject: [PATCH] dt-bindings: nvmem: add nvmem-cell-cells property

From: Peng Fan <[email protected]>

The driver has been using this property, so add it.

Signed-off-by: Peng Fan <[email protected]>
---
Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
index 75bb93dda9df..3fc3982da102 100644
--- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
@@ -67,6 +67,9 @@ patternProperties:
description:
Size in bit within the address range specified by reg.

+ "#nvmem-cell-cells":
+ const: 1
+
additionalProperties: true

examples:
--
2.37.1

2023-05-05 10:40:23

by Rob Herring

Subject: Re: [PATCH] dt-bindings: nvmem: add nvmem-cell-cells property

On Fri, 05 May 2023 17:19:06 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The driver has been using this property, so add it.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/nvmem/nvmem.yaml:71:10: [warning] wrong indentation: expected 8 but found 9 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

2023-05-05 16:23:20

by Rob Herring

Subject: Re: [PATCH] dt-bindings: nvmem: add nvmem-cell-cells property

On Fri, May 05, 2023 at 05:19:06PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The driver has been using this property, so add it.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> index 75bb93dda9df..3fc3982da102 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> @@ -67,6 +67,9 @@ patternProperties:
> description:
> Size in bit within the address range specified by reg.
>
> + "#nvmem-cell-cells":
> + const: 1

I don't think we can globally set this to 1. You should have a specific
nvmem layout that uses and defines it.

Rob