2023-05-08 11:58:36

by Peng Fan (OSS)

[permalink] [raw]
Subject: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93

From: Peng Fan <[email protected]>

Add i.MX93 OCOTP support

Signed-off-by: Peng Fan <[email protected]>
---

V2:
Reuse imx-ocotp.yaml
Based on https://lore.kernel.org/all/[email protected]/

Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
index 0784d71ae8f9..99e60d713dac 100644
--- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
+++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/nvmem/imx-ocotp.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

-title: Freescale i.MX6 On-Chip OTP Controller (OCOTP)
+title: Freescale i.MX On-Chip OTP Controller (OCOTP)

maintainers:
- Anson Huang <[email protected]>
@@ -12,7 +12,7 @@ maintainers:
description: |
This binding represents the on-chip eFuse OTP controller found on
i.MX6Q/D, i.MX6DL/S, i.MX6SL, i.MX6SX, i.MX6UL, i.MX6ULL/ULZ, i.MX6SLL,
- i.MX7D/S, i.MX7ULP, i.MX8MQ, i.MX8MM, i.MX8MN and i.MX8MP SoCs.
+ i.MX7D/S, i.MX7ULP, i.MX8MQ, i.MX8MM, i.MX8MN i.MX8MP and i.MX93 SoCs.

allOf:
- $ref: nvmem.yaml#
@@ -32,6 +32,7 @@ properties:
- fsl,imx7ulp-ocotp
- fsl,imx8mq-ocotp
- fsl,imx8mm-ocotp
+ - fsl,imx93-ocotp
- const: syscon
- items:
- enum:
--
2.37.1


2023-05-08 12:47:28

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93


On Mon, 08 May 2023 19:46:38 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add i.MX93 OCOTP support
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
>
> V2:
> Reuse imx-ocotp.yaml
> Based on https://lore.kernel.org/all/[email protected]/
>
> Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml

doc reference errors (make refcheckdocs):
Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst
MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

2023-05-09 00:58:50

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93

Hi Rob,

> Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93
>
>
> On Mon, 08 May 2023 19:46:38 +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Add i.MX93 OCOTP support
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> >
> > V2:
> > Reuse imx-ocotp.yaml
> > Based on
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Fall%2F20230506064128.34005-1-
> krzysztof.kozlowski%40linar
> >
> o.org%2F&data=05%7C01%7Cpeng.fan%40nxp.com%7Ca420ce0c500d4c7e7
> 63a08db4
> >
> fbfa1d7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638191456
> 69328409
> >
> 9%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI
> iLCJBTiI6
> >
> Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V7QDS9Ko3cvQ3q
> rR%2FzlHVVI
> > NImlIzkkqBmDHPFme5oI%3D&reserved=0
> >
> > Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
[Peng Fan]

I think the following errors are not related this patch. I not touch
pcie, camera in this patch.

Thanks,
Peng.

>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/media/rockchip-
> isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.exampl
> e.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-
> ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not
> allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks'
> were unexpected)
> From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
>
> doc reference errors (make refcheckdocs):
> Documentation/usb/gadget_uvc.rst: Documentation/userspace-
> api/media/v4l/pixfmt-packed.yuv.rst
> MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml
>
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hwork.ozlabs.org%2Fproject%2Fdevicetree-
> bindings%2Fpatch%2F20230508114639.1525521-1-
> peng.fan%40oss.nxp.com&data=05%7C01%7Cpeng.fan%40nxp.com%7Ca42
> 0ce0c500d4c7e763a08db4fbfa1d7%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C638191456693284099%7CUnknown%7CTWFpbGZsb3d8eyJW
> IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000%7C%7C%7C&sdata=BagDUtBuSrbiQNnFQkFSiXMUwzpdxZFwuyizKx%
> 2BnEhs%3D&reserved=0
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself.
> Note that DT_SCHEMA_FILES can be set to your schema file to speed up
> checking your schema. However, it must be unset to test all examples with
> your schema.

2023-05-09 06:56:08

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93

On 08/05/2023 13:46, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add i.MX93 OCOTP support
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
>
> V2:


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-05-09 07:07:40

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93

On 09/05/2023 02:49, Peng Fan wrote:
> Hi Rob,
>
>> Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93
>>
>>
>> On Mon, 08 May 2023 19:46:38 +0800, Peng Fan (OSS) wrote:
>>> From: Peng Fan <[email protected]>
>>>
>>> Add i.MX93 OCOTP support
>>>
>>> Signed-off-by: Peng Fan <[email protected]>
>>> ---
>>>
>>> V2:
>>> Reuse imx-ocotp.yaml
>>> Based on
>>>
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
>>> .kernel.org%2Fall%2F20230506064128.34005-1-
>> krzysztof.kozlowski%40linar
>>>
>> o.org%2F&data=05%7C01%7Cpeng.fan%40nxp.com%7Ca420ce0c500d4c7e7
>> 63a08db4
>>>
>> fbfa1d7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638191456
>> 69328409
>>>
>> 9%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI
>> iLCJBTiI6
>>>
>> Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=V7QDS9Ko3cvQ3q
>> rR%2FzlHVVI
>>> NImlIzkkqBmDHPFme5oI%3D&reserved=0
>>>
>>> Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m
>> dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
> [Peng Fan]
>
> I think the following errors are not related this patch. I not touch
> pcie, camera in this patch.

Yes, these errors can be ignored.

Best regards,
Krzysztof

2023-05-31 14:18:44

by Srinivas Kandagatla

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93


On Mon, 08 May 2023 19:46:38 +0800, Peng Fan (OSS) wrote:
> Add i.MX93 OCOTP support
>
>

Applied, thanks!

[1/2] dt-bindings: nvmem: imx-ocotp: support i.MX93
commit: 42d033c4e47b9490cd9351c0eacb0b7dedb179e4
[2/2] nvmem: imx: support i.MX93 OCOTP
commit: 4d47e9a76d5fd3008e69c91dccfb52ca02624c5a

Best regards,
--
Srinivas Kandagatla <[email protected]>