2023-07-23 14:22:43

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: qcom: sc8180x: align USB DWC3 clocks with bindings

Bindings require different order of clocks for USB DWC3 nodes (sleep
before mock_utmi).

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index e39341435289..87c00450f068 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -2572,14 +2572,14 @@ usb_prim: usb@a6f8800 {
clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
<&gcc GCC_USB30_PRIM_MASTER_CLK>,
<&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>,
- <&gcc GCC_USB30_PRIM_MOCK_UTMI_CLK>,
<&gcc GCC_USB30_PRIM_SLEEP_CLK>,
+ <&gcc GCC_USB30_PRIM_MOCK_UTMI_CLK>,
<&gcc GCC_USB3_SEC_CLKREF_CLK>;
clock-names = "cfg_noc",
"core",
"iface",
- "mock_utmi",
"sleep",
+ "mock_utmi",
"xo";
resets = <&gcc GCC_USB30_PRIM_BCR>;
power-domains = <&gcc USB30_PRIM_GDSC>;
@@ -2618,14 +2618,14 @@ usb_sec: usb@a8f8800 {
clocks = <&gcc GCC_CFG_NOC_USB3_SEC_AXI_CLK>,
<&gcc GCC_USB30_SEC_MASTER_CLK>,
<&gcc GCC_AGGRE_USB3_SEC_AXI_CLK>,
- <&gcc GCC_USB30_SEC_MOCK_UTMI_CLK>,
<&gcc GCC_USB30_SEC_SLEEP_CLK>,
+ <&gcc GCC_USB30_SEC_MOCK_UTMI_CLK>,
<&gcc GCC_USB3_SEC_CLKREF_CLK>;
clock-names = "cfg_noc",
"core",
"iface",
- "mock_utmi",
"sleep",
+ "mock_utmi",
"xo";
resets = <&gcc GCC_USB30_SEC_BCR>;
power-domains = <&gcc USB30_SEC_GDSC>;
--
2.34.1

2023-07-23 14:25:56

by Krzysztof Kozlowski

Subject: [PATCH 2/2] arm64: dts: qcom: sdm630: align USB DWC3 clocks with bindings

Bindings require different order of clocks for USB DWC3 nodes (sleep
before mock_utmi).

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm630.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index 83afce56a7b0..25124acf705f 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -1416,10 +1416,10 @@ usb2: usb@c2f8800 {

clocks = <&gcc GCC_CFG_NOC_USB2_AXI_CLK>,
<&gcc GCC_USB20_MASTER_CLK>,
- <&gcc GCC_USB20_MOCK_UTMI_CLK>,
- <&gcc GCC_USB20_SLEEP_CLK>;
+ <&gcc GCC_USB20_SLEEP_CLK>,
+ <&gcc GCC_USB20_MOCK_UTMI_CLK>;
clock-names = "cfg_noc", "core",
- "mock_utmi", "sleep";
+ "sleep", "mock_utmi";

assigned-clocks = <&gcc GCC_USB20_MOCK_UTMI_CLK>,
<&gcc GCC_USB20_MASTER_CLK>;
--
2.34.1

2023-07-24 11:06:05

by Konrad Dybcio

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sdm630: align USB DWC3 clocks with bindings

On 23.07.2023 16:18, Krzysztof Kozlowski wrote:
> Bindings require different order of clocks for USB DWC3 nodes (sleep
> before mock_utmi).
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-07-24 11:13:53

by Konrad Dybcio

Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8180x: align USB DWC3 clocks with bindings

On 23.07.2023 16:18, Krzysztof Kozlowski wrote:
> Bindings require different order of clocks for USB DWC3 nodes (sleep
> before mock_utmi).
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2023-09-19 23:09:58

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: sc8180x: align USB DWC3 clocks with bindings

On Sun, 23 Jul 2023 16:18:48 +0200, Krzysztof Kozlowski wrote:
> Bindings require different order of clocks for USB DWC3 nodes (sleep
> before mock_utmi).
>
>

Applied, thanks!

[1/2] arm64: dts: qcom: sc8180x: align USB DWC3 clocks with bindings
commit: 1e5fd509fef100aec1cdfc3f2d60b9eccd980de4
[2/2] arm64: dts: qcom: sdm630: align USB DWC3 clocks with bindings
commit: 5af94c7c6578b39f03efbb9b5ee1809e894a0e58

Best regards,
--
Bjorn Andersson <[email protected]>