2023-08-21 08:40:13

by Krzysztof Kozlowski

Subject: [PATCH RFT v2] arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side

Qualcomm Embedded USB Debugger (EUD) second port should point to Type-C
USB connector. Such connector was defined directly in root node of
sc7280.dtsi which is clearly wrong. SC7280 is a chip, so physically it
does not have USB Type-C port. The connector is usually accessible
through some USB switch or controller.

Doug Anderson said that he wasn't ever able to use EUD on Herobrine
boards, probably because of invalid or missing DTS description - DTS is
saying EUD is on usb_2 node, which is connected to a USB Hub, not to the
Type-C port.

Correct the EUD/USB connector topology by removing the top-level fake
USB connector and EUD port pointing to it, and disabling the incomplete
EUD device node.

This fixes also dtbs_check warnings:

sc7280-herobrine-crd.dtb: connector: ports:port@0: 'reg' is a required property

Link: https://lore.kernel.org/all/CAD=FV=Xt26=rBf99mzkAuwwtb2f-jnKtnHaEhXnthz0a5zke4Q@mail.gmail.com/
Fixes: 9ee402ccfeb1 ("arm64: dts: qcom: sc7280: Fix EUD dt node syntax")
Cc: Souradeep Chowdhury <[email protected]>
Cc: Bhupesh Sharma <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Not tested on hardware.

Changes in v2:
1. Disable the EUD node and do not add ports/connector in boards, as
discussed with Doug.

v1: https://lore.kernel.org/all/CAD=FV=Xt26=rBf99mzkAuwwtb2f-jnKtnHaEhXnthz0a5zke4Q@mail.gmail.com/
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 21 ++-------------------
1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 4abe5fb8e6c3..233cfcbd0b4a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -649,18 +649,6 @@ cpu7_opp_3014mhz: opp-3014400000 {
};
};

- eud_typec: connector {
- compatible = "usb-c-connector";
-
- ports {
- port@0 {
- con_eud: endpoint {
- remote-endpoint = <&eud_con>;
- };
- };
- };
- };
-
memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the size */
@@ -3623,6 +3611,8 @@ eud: eud@88e0000 {
<0 0x88e2000 0 0x1000>;
interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;

+ status = "disabled";
+
ports {
#address-cells = <1>;
#size-cells = <0>;
@@ -3633,13 +3623,6 @@ eud_ep: endpoint {
remote-endpoint = <&usb2_role_switch>;
};
};
-
- port@1 {
- reg = <1>;
- eud_con: endpoint {
- remote-endpoint = <&con_eud>;
- };
- };
};
};

--
2.34.1

2023-09-20 04:09:05

by Bjorn Andersson

Subject: Re: [PATCH RFT v2] arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side

On Sun, 20 Aug 2023 09:56:26 +0200, Krzysztof Kozlowski wrote:
> Qualcomm Embedded USB Debugger (EUD) second port should point to Type-C
> USB connector. Such connector was defined directly in root node of
> sc7280.dtsi which is clearly wrong. SC7280 is a chip, so physically it
> does not have USB Type-C port. The connector is usually accessible
> through some USB switch or controller.
>
> Doug Anderson said that he wasn't ever able to use EUD on Herobrine
> boards, probably because of invalid or missing DTS description - DTS is
> saying EUD is on usb_2 node, which is connected to a USB Hub, not to the
> Type-C port.
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side
commit: 39c8af78cbefb8c71a5ad1fa088e761ef418f0a0

Best regards,
--
Bjorn Andersson <[email protected]>