2023-08-09 23:29:48

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH v3 0/6] MMCC MSM8998 fixes

8998 has a couple of issues related to its clock controllers. This series
attemps to fix some of them.

The DT patch should go in first for bisectability, otherwise
clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
considered always-on.

This series results in less "clk stuck at 'on/off'" messages and should
marginally reduce power consumption.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Changes in v3:
- Make the commit message more meaningful in patch 6 (krzk)
- Pick up tags
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Update bindings
- Separate out the dt patch into two
- Pick up tags
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Konrad Dybcio (6):
arm64: dts: qcom: msm8998: Drop bus clock reference from MMSS SMMU
arm64: dts: qcom: msm8998: Add missing power domain to MMSS SMMU
clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks
clk: qcom: mmcc-msm8998: Fix the SMMU GDSC
dt-bindings: arm-smmu: Fix MSM8998 clocks description

.../devicetree/bindings/iommu/arm,smmu.yaml | 41 ++++++++++++++++++++++
arch/arm64/boot/dts/qcom/msm8998.dtsi | 8 +++--
drivers/clk/qcom/gcc-msm8998.c | 6 ++--
drivers/clk/qcom/mmcc-msm8998.c | 7 +++-
4 files changed, 55 insertions(+), 7 deletions(-)
---
base-commit: 21ef7b1e17d039053edaeaf41142423810572741
change-id: 20230531-topic-8998_mmssclk-fd4b2fb7f8c1

Best regards,
--
Konrad Dybcio <[email protected]>



2023-08-11 12:16:22

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH v3 0/6] MMCC MSM8998 fixes

On Wed, 09 Aug 2023 21:20:23 +0200, Konrad Dybcio wrote:
> 8998 has a couple of issues related to its clock controllers. This series
> attemps to fix some of them.
>
> The DT patch should go in first for bisectability, otherwise
> clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
> considered always-on.
>
> [...]

Applied bindings patch to will (for-joerg/arm-smmu/bindings), thanks!

[6/6] dt-bindings: arm-smmu: Fix MSM8998 clocks description
https://git.kernel.org/will/c/b606e2e8eded

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

2023-08-14 06:20:09

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v3 0/6] MMCC MSM8998 fixes


On Wed, 09 Aug 2023 21:20:23 +0200, Konrad Dybcio wrote:
> 8998 has a couple of issues related to its clock controllers. This series
> attemps to fix some of them.
>
> The DT patch should go in first for bisectability, otherwise
> clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
> considered always-on.
>
> [...]

Applied, thanks!

[3/6] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
commit: a6f1e8623836bb6ce64c347d110ecb6259ae73c4
[4/6] clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks
(no commit info)

Best regards,
--
Bjorn Andersson <[email protected]>

2023-09-20 17:21:31

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v3 0/6] MMCC MSM8998 fixes


On Wed, 09 Aug 2023 21:20:23 +0200, Konrad Dybcio wrote:
> 8998 has a couple of issues related to its clock controllers. This series
> attemps to fix some of them.
>
> The DT patch should go in first for bisectability, otherwise
> clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
> considered always-on.
>
> [...]

Applied, thanks!

[3/6] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
(no commit info)
[4/6] clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks
commit: 9906c4140897bbdbff7bb71c6ae67903cb9954ce
[5/6] clk: qcom: mmcc-msm8998: Fix the SMMU GDSC
commit: 1fc62c8347397faf4e18249e88ecd4470c0a5357

Best regards,
--
Bjorn Andersson <[email protected]>