2023-07-12 08:02:01

by Luca Weiss

Subject: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc

Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
should provide them in the dt, which I missed in the commit adding the
mdss nodes.

Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
index b6ae4b7936e3..d2d09f2f3cee 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
@@ -404,8 +404,8 @@ mmcc: clock-controller@fd8c0000 {
<&gcc GPLL0_VOTE>,
<&gcc GPLL1_VOTE>,
<&rpmcc RPM_SMD_GFX3D_CLK_SRC>,
- <0>,
- <0>;
+ <&mdss_dsi0_phy 1>,
+ <&mdss_dsi0_phy 0>;
clock-names = "xo",
"mmss_gpll0_vote",
"gpll0_vote",

---
base-commit: 40b055fe7f276cf2c1da47316c52f2ff9255a68a
change-id: 20230712-msm8226-dsi-clock-fixup-ad8bfd411eb9

Best regards,
--
Luca Weiss <[email protected]>

2023-07-15 14:30:11

by Konrad Dybcio

Subject: Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc

On 12.07.2023 09:52, Luca Weiss wrote:
> Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> should provide them in the dt, which I missed in the commit adding the
> mdss nodes.
>
> Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
> Signed-off-by: Luca Weiss <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> index b6ae4b7936e3..d2d09f2f3cee 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> @@ -404,8 +404,8 @@ mmcc: clock-controller@fd8c0000 {
> <&gcc GPLL0_VOTE>,
> <&gcc GPLL1_VOTE>,
> <&rpmcc RPM_SMD_GFX3D_CLK_SRC>,
> - <0>,
> - <0>;
> + <&mdss_dsi0_phy 1>,
> + <&mdss_dsi0_phy 0>;
> clock-names = "xo",
> "mmss_gpll0_vote",
> "gpll0_vote",
>
> ---
> base-commit: 40b055fe7f276cf2c1da47316c52f2ff9255a68a
> change-id: 20230712-msm8226-dsi-clock-fixup-ad8bfd411eb9
>
> Best regards,

2023-09-23 06:32:58

by Luca Weiss

Subject: Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc

On Samstag, 15. Juli 2023 16:08:37 CEST Konrad Dybcio wrote:
> On 12.07.2023 09:52, Luca Weiss wrote:
> > Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> > should provide them in the dt, which I missed in the commit adding the
> > mdss nodes.
> >
> > Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
> > Signed-off-by: Luca Weiss <[email protected]>
> > ---
>
> Reviewed-by: Konrad Dybcio <[email protected]>
>
> Konrad

Hi Bjorn,

this patch is still waiting to be picked up :) Would be nice to get it into
v6.7.

Regards
Luca

>
> > arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> > b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi index
> > b6ae4b7936e3..d2d09f2f3cee 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> > +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> > @@ -404,8 +404,8 @@ mmcc: clock-controller@fd8c0000 {
> >
> > <&gcc GPLL0_VOTE>,
> > <&gcc GPLL1_VOTE>,
> > <&rpmcc RPM_SMD_GFX3D_CLK_SRC>,
> >
> > - <0>,
> > - <0>;
> > + <&mdss_dsi0_phy 1>,
> > + <&mdss_dsi0_phy 0>;
> >
> > clock-names = "xo",
> >
> > "mmss_gpll0_vote",
> > "gpll0_vote",
> >
> > ---
> > base-commit: 40b055fe7f276cf2c1da47316c52f2ff9255a68a
> > change-id: 20230712-msm8226-dsi-clock-fixup-ad8bfd411eb9
> >
> > Best regards,

2023-09-23 20:52:44

by Dmitry Baryshkov

Subject: Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc

On Wed, 12 Jul 2023 at 10:53, Luca Weiss <[email protected]> wrote:
>
> Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> should provide them in the dt, which I missed in the commit adding the
> mdss nodes.
>
> Fixes: d5fb01ad5eb4 ("ARM: dts: qcom: msm8226: Add mdss nodes")
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2023-10-22 16:24:27

by Bjorn Andersson

Subject: Re: [PATCH] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc

On Wed, 12 Jul 2023 09:52:07 +0200, Luca Weiss wrote:
> Some mmcc clocks have dsi0pll & dsi0pllbyte as clock parents so we
> should provide them in the dt, which I missed in the commit adding the
> mdss nodes.
>
>

Applied, thanks!

[1/1] ARM: dts: qcom: msm8226: provide dsi phy clocks to mmcc
commit: 836d083524888069cd358776a4e6c4ceec04962e

Best regards,
--
Bjorn Andersson <[email protected]>