>
>If Luming would not move the mce.c file from x86-64 to i386 then
>his patch would be only 1/4 as big. I dont know why he does this
>anyways, it seems completely pointless.
mce.c mce.h and mce_intel.c are moved from x86_64 to i386. so the
patch is very big. The motivation is to share mce code between
x86_64 and i386 and avoid duplicate code in x86_64 and i386.
I don't know whether I completely understand what you point.
Correct me if I am wrong.
On Mon, May 02, 2005 at 09:01:53AM +0800, Guo, Racing wrote:
> >
> >If Luming would not move the mce.c file from x86-64 to i386 then
> >his patch would be only 1/4 as big. I dont know why he does this
> >anyways, it seems completely pointless.
>
> mce.c mce.h and mce_intel.c are moved from x86_64 to i386. so the
> patch is very big. The motivation is to share mce code between
> x86_64 and i386 and avoid duplicate code in x86_64 and i386.
> I don't know whether I completely understand what you point.
> Correct me if I am wrong.
You can share code as well by linking it from x86-64 into i386,
not only the other way round. This is already done for earlyprintk
for example.
-Andi