2024-01-23 17:38:07

by Frank Li

Subject: [PATCH 1/1] dmaengine: fix is_slave_direction() return false when DMA_DEV_TO_DEV

is_slave_direction() should return true when direction is DMA_DEV_TO_DEV.

Fixes: 49920bc66984 ("dmaengine: add new enum dma_transfer_direction")
Signed-off-by: Frank Li <[email protected]>
---
include/linux/dmaengine.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 3df70d6131c8f..752dbde4cec1f 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -953,7 +953,8 @@ static inline int dmaengine_slave_config(struct dma_chan *chan,

static inline bool is_slave_direction(enum dma_transfer_direction direction)
{
- return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
+ return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM) ||
+ (direction == DMA_DEV_TO_DEV);
}

static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_single(
--
2.34.1

2024-01-30 16:51:06

by Vinod Koul

Subject: Re: [PATCH 1/1] dmaengine: fix is_slave_direction() return false when DMA_DEV_TO_DEV

On Tue, 23 Jan 2024 12:28:41 -0500, Frank Li wrote:
> is_slave_direction() should return true when direction is DMA_DEV_TO_DEV.
>
>

Applied, thanks!

[1/1] dmaengine: fix is_slave_direction() return false when DMA_DEV_TO_DEV
commit: a22fe1d6dec7e98535b97249fdc95c2be79120bb

Best regards,
--
~Vinod