From: Frank Wunderlich <[email protected]>
Add -regulator suffix to regulator names on Banana Pi R2 Pro board as
discussed on Mailinglist
Signed-off-by: Frank Wunderlich <[email protected]>
---
https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 7a8d55a898f5..432469697544 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -46,7 +46,7 @@ green_led: led-1 {
};
};
- dc_12v: dc-12v {
+ dc_12v: dc-12v-regulator {
compatible = "regulator-fixed";
regulator-name = "dc_12v";
regulator-always-on;
@@ -66,7 +66,7 @@ hdmi_con_in: endpoint {
};
};
- vcc3v3_sys: vcc3v3-sys {
+ vcc3v3_sys: vcc3v3-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
regulator-always-on;
@@ -76,7 +76,7 @@ vcc3v3_sys: vcc3v3-sys {
vin-supply = <&dc_12v>;
};
- vcc5v0_sys: vcc5v0-sys {
+ vcc5v0_sys: vcc5v0-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_sys";
regulator-always-on;
@@ -146,7 +146,7 @@ vcc3v3_ngff: vcc3v3-ngff-regulator {
vin-supply = <&vcc3v3_pi6c_05>;
};
- vcc5v0_usb: vcc5v0_usb {
+ vcc5v0_usb: vcc5v0_usb-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_usb";
regulator-always-on;
@@ -156,7 +156,7 @@ vcc5v0_usb: vcc5v0_usb {
vin-supply = <&dc_12v>;
};
- vcc5v0_usb_host: vcc5v0-usb-host {
+ vcc5v0_usb_host: vcc5v0-usb-host-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
@@ -168,7 +168,7 @@ vcc5v0_usb_host: vcc5v0-usb-host {
vin-supply = <&vcc5v0_usb>;
};
- vcc5v0_usb_otg: vcc5v0-usb-otg {
+ vcc5v0_usb_otg: vcc5v0-usb-otg-regulator {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
--
2.34.1
On 06/09/2022 17:55, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Add -regulator suffix to regulator names on Banana Pi R2 Pro board as
> discussed on Mailinglist
>
> Signed-off-by: Frank Wunderlich <[email protected]>
> ---
> https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 7a8d55a898f5..432469697544 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -46,7 +46,7 @@ green_led: led-1 {
> };
> };
>
> - dc_12v: dc-12v {
> + dc_12v: dc-12v-regulator {
> compatible = "regulator-fixed";
> regulator-name = "dc_12v";
> regulator-always-on;
> @@ -66,7 +66,7 @@ hdmi_con_in: endpoint {
> };
> };
>
> - vcc3v3_sys: vcc3v3-sys {
> + vcc3v3_sys: vcc3v3-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc3v3_sys";
> regulator-always-on;
> @@ -76,7 +76,7 @@ vcc3v3_sys: vcc3v3-sys {
> vin-supply = <&dc_12v>;
> };
>
> - vcc5v0_sys: vcc5v0-sys {
> + vcc5v0_sys: vcc5v0-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_sys";
> regulator-always-on;
> @@ -146,7 +146,7 @@ vcc3v3_ngff: vcc3v3-ngff-regulator {
> vin-supply = <&vcc3v3_pi6c_05>;
> };
>
> - vcc5v0_usb: vcc5v0_usb {
> + vcc5v0_usb: vcc5v0_usb-regulator {
While at it drop underscore in node name (hyphen is ok).
Best regards,
Krzysztof
Am Dienstag, 6. September 2022, 17:55:03 CEST schrieb Frank Wunderlich:
> From: Frank Wunderlich <[email protected]>
>
> Add -regulator suffix to regulator names on Banana Pi R2 Pro board as
> discussed on Mailinglist
>
> Signed-off-by: Frank Wunderlich <[email protected]>
looks like my b4 thanks mail got lost, so manually:
applied for 6.1
Thanks
Heiko
> ---
> https://patchwork.kernel.org/project/linux-rockchip/patch/[email protected]/
> ---
> arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 7a8d55a898f5..432469697544 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -46,7 +46,7 @@ green_led: led-1 {
> };
> };
>
> - dc_12v: dc-12v {
> + dc_12v: dc-12v-regulator {
> compatible = "regulator-fixed";
> regulator-name = "dc_12v";
> regulator-always-on;
> @@ -66,7 +66,7 @@ hdmi_con_in: endpoint {
> };
> };
>
> - vcc3v3_sys: vcc3v3-sys {
> + vcc3v3_sys: vcc3v3-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc3v3_sys";
> regulator-always-on;
> @@ -76,7 +76,7 @@ vcc3v3_sys: vcc3v3-sys {
> vin-supply = <&dc_12v>;
> };
>
> - vcc5v0_sys: vcc5v0-sys {
> + vcc5v0_sys: vcc5v0-sys-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_sys";
> regulator-always-on;
> @@ -146,7 +146,7 @@ vcc3v3_ngff: vcc3v3-ngff-regulator {
> vin-supply = <&vcc3v3_pi6c_05>;
> };
>
> - vcc5v0_usb: vcc5v0_usb {
> + vcc5v0_usb: vcc5v0_usb-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_usb";
> regulator-always-on;
> @@ -156,7 +156,7 @@ vcc5v0_usb: vcc5v0_usb {
> vin-supply = <&dc_12v>;
> };
>
> - vcc5v0_usb_host: vcc5v0-usb-host {
> + vcc5v0_usb_host: vcc5v0-usb-host-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> gpio = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
> @@ -168,7 +168,7 @@ vcc5v0_usb_host: vcc5v0-usb-host {
> vin-supply = <&vcc5v0_usb>;
> };
>
> - vcc5v0_usb_otg: vcc5v0-usb-otg {
> + vcc5v0_usb_otg: vcc5v0-usb-otg-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
>