2020-01-16 06:39:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the kunit-next tree

Hi all,

After merging the kunit-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

x86_64-linux-gnu-ld: drivers/base/test/property-entry-test.o: in function `kunit_test_suites_init':
property-entry-test.c:(.text+0x26): undefined reference to `kunit_run_tests'
x86_64-linux-gnu-ld: drivers/base/test/property-entry-test.o: in function `pe_test_reference':
property-entry-test.c:(.text+0x275): undefined reference to `kunit_binary_assert_format'
x86_64-linux-gnu-ld: property-entry-test.c:(.text+0x2c4): undefined reference to `kunit_do_assertion'

and lots more ...

Caused by commit

27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")

from the pm tree interacting with commit

35c57fc3f8ea ("kunit: building kunit as a module breaks allmodconfig")

I have disabled CONFIG_KUNIT_DRIVER_PE_TEST for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-01-16 11:25:58

by Alan Maguire

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the kunit-next tree

On Thu, 16 Jan 2020, Stephen Rothwell wrote:

> Hi all,
>
> After merging the kunit-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> x86_64-linux-gnu-ld: drivers/base/test/property-entry-test.o: in function `kunit_test_suites_init':
> property-entry-test.c:(.text+0x26): undefined reference to `kunit_run_tests'
> x86_64-linux-gnu-ld: drivers/base/test/property-entry-test.o: in function `pe_test_reference':
> property-entry-test.c:(.text+0x275): undefined reference to `kunit_binary_assert_format'
> x86_64-linux-gnu-ld: property-entry-test.c:(.text+0x2c4): undefined reference to `kunit_do_assertion'
>
> and lots more ...
>
> Caused by commit
>
> 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
>
> from the pm tree interacting with commit
>
> 35c57fc3f8ea ("kunit: building kunit as a module breaks allmodconfig")
>
> I have disabled CONFIG_KUNIT_DRIVER_PE_TEST for today.
>

Apologies again, I should have explicitly specified that
CONFIG_KUNIT_DRIVER_PE_TEST depends on KUNIT=y; I've
sent a patch to fix this:

https://lore.kernel.org/lkml/[email protected]/T/#u

Thank you!

Alan

> --
> Cheers,
> Stephen Rothwell
>

2020-01-16 23:41:29

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the kunit-next tree

On Thursday, January 16, 2020 12:23:09 PM CET Alan Maguire wrote:
> On Thu, 16 Jan 2020, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > After merging the kunit-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > x86_64-linux-gnu-ld: drivers/base/test/property-entry-test.o: in function `kunit_test_suites_init':
> > property-entry-test.c:(.text+0x26): undefined reference to `kunit_run_tests'
> > x86_64-linux-gnu-ld: drivers/base/test/property-entry-test.o: in function `pe_test_reference':
> > property-entry-test.c:(.text+0x275): undefined reference to `kunit_binary_assert_format'
> > x86_64-linux-gnu-ld: property-entry-test.c:(.text+0x2c4): undefined reference to `kunit_do_assertion'
> >
> > and lots more ...
> >
> > Caused by commit
> >
> > 27f9d7e984d9 ("software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST")
> >
> > from the pm tree interacting with commit
> >
> > 35c57fc3f8ea ("kunit: building kunit as a module breaks allmodconfig")
> >
> > I have disabled CONFIG_KUNIT_DRIVER_PE_TEST for today.
> >
>
> Apologies again, I should have explicitly specified that
> CONFIG_KUNIT_DRIVER_PE_TEST depends on KUNIT=y; I've
> sent a patch to fix this:
>
> https://lore.kernel.org/lkml/[email protected]/T/#u

I have folded this into the original patch and remerged the linux-next branch.

Thanks!



2024-02-28 03:27:16

by Shuah Khan

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the kunit-next tree

On 2/27/24 19:48, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kunit-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>

> Caused by commit
>
> e00c5a9fa617 ("kunit: Annotate _MSG assertion variants with gnu printf specifiers")
>
> Please fix all the current problems before applying a patch to warn
> about them.
>
> I have used the kunit-next tree from next-20240227 for today.

This is my bad. I should have dropped this patch when I couldn't
apply the patch that fixed the drivers/gpu/drm/tests/drm_buddy_test.c

It is fixed now. I dropped the problem commit

e00c5a9fa617 ("kunit: Annotate _MSG assertion variants with gnu printf specifiers")

thanks,
-- Shuah