> ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs);
I've done 50 problem reproduces on different flash devices and made sure that the assertion was not triggered. See record.txt for details.
-----邮件原件-----
发件人: chengzhihao
发送时间: 2019年8月14日 9:20
收件人: 'Richard Weinberger' <[email protected]>
抄送: Richard Weinberger <[email protected]>; Sascha Hauer <[email protected]>; Artem Bityutskiy <[email protected]>; zhangyi (F) <[email protected]>; [email protected]; LKML <[email protected]>
主题: 答复: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps
Sure, I'll do more tests on different machines to check the assertion. I'm trying to understand when this assertion will be triggered. Although I haven't found this assertion be triggered so far in several tests on x86_64(qemu).
-----邮件原件-----
发件人: Richard Weinberger [mailto:[email protected]]
发送时间: 2019年8月14日 5:44
收件人: chengzhihao <[email protected]>
抄送: Richard Weinberger <[email protected]>; Sascha Hauer <[email protected]>; Artem Bityutskiy <[email protected]>; zhangyi (F) <[email protected]>; [email protected]; LKML <[email protected]>
主题: Re: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps
On Tue, Jul 30, 2019 at 3:21 AM chengzhihao <[email protected]> wrote:
>
> OK, that's fine, and I will continue to understand more implementation code related to this part.
I think we can go with the realloc() approach for now.
Can you please check whether the assert() triggers?
--
Thanks,
//richard
On Fri, Aug 16, 2019 at 10:01 AM chengzhihao <[email protected]> wrote:
>
> > ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs);
>
> I've done 50 problem reproduces on different flash devices and made sure that the assertion was not triggered. See record.txt for details.
Thanks for letting me know. :)
I need to give this another thought, then we can apply it for -rc2.
在 2019/9/16 6:00, Richard Weinberger 写道:
> On Fri, Aug 16, 2019 at 10:01 AM chengzhihao <[email protected]> wrote:
>>
>>> ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs);
>>
>> I've done 50 problem reproduces on different flash devices and made sure that the assertion was not triggered. See record.txt for details.
>
> Thanks for letting me know. :)
> I need to give this another thought, then we can apply it for -rc2.
>
ACK. :)
Can the current modification method be confirmed?
在 2019/9/16 6:00, Richard Weinberger 写道:
> I need to give this another thought
ping.
在 2019/9/16 6:00, Richard Weinberger 写道:
> On Fri, Aug 16, 2019 at 10:01 AM chengzhihao <[email protected]> wrote:
>>> ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs);
>> I've done 50 problem reproduces on different flash devices and made sure that the assertion was not triggered. See record.txt for details.
> Thanks for letting me know. :)
> I need to give this another thought, then we can apply it for -rc2.
>