2015-08-17 01:05:40

by Brad Hubbard

Subject: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings

ceph: remove redundant test of head->safe and silence static analysis warnings

Signed-off-by: Brad Hubbard <[email protected]>
---
fs/ceph/mds_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 6aa07af..6e196ee 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)
mutex_unlock(&mdsc->mutex);
goto out;
}
- if (req->r_got_safe && !head->safe) {
+ if (req->r_got_safe) {
pr_warn("got unsafe after safe on %llu from mds%d\n",
tid, mds);
mutex_unlock(&mdsc->mutex);
--

2015-08-18 02:34:09

by Yan, Zheng

Subject: Re: [PATCH] ceph: remove redundant test of head->safe and silence static analysis warnings

> On Aug 17, 2015, at 09:05, Brad Hubbard <[email protected]> wrote:
>
> ceph: remove redundant test of head->safe and silence static analysis warnings
>
> Signed-off-by: Brad Hubbard <[email protected]>
> ---
> fs/ceph/mds_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 6aa07af..6e196ee 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2411,7 +2411,7 @@ static void handle_reply(struct ceph_mds_session *session, struct ceph_msg *msg)
> mutex_unlock(&mdsc->mutex);
> goto out;
> }
> - if (req->r_got_safe && !head->safe) {
> + if (req->r_got_safe) {
> pr_warn("got unsafe after safe on %llu from mds%d\n",
> tid, mds);
> mutex_unlock(&mdsc->mutex);
> --

added to our testing branch,

Thanks
Yan, Zheng-