2018-01-31 10:00:55

by Yisheng Xie

Subject: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

ion_page_pool.c now is used to apply pool APIs for system heap, which do
not need do any initial at device_initcall.

Meanwhile, this patch also remove some useless include files.

Signed-off-by: Yisheng Xie <[email protected]>
---
drivers/staging/android/ion/ion_page_pool.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index 817849d..3c1eba5 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -14,12 +14,7 @@
*
*/

-#include <linux/debugfs.h>
-#include <linux/dma-mapping.h>
-#include <linux/err.h>
-#include <linux/fs.h>
#include <linux/list.h>
-#include <linux/init.h>
#include <linux/slab.h>
#include <linux/swap.h>

@@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
{
kfree(pool);
}
-
-static int __init ion_page_pool_init(void)
-{
- return 0;
-}
-device_initcall(ion_page_pool_init);
--
1.7.12.4

2018-01-31 12:58:11

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
>
> Meanwhile, this patch also remove some useless include files.

Please only do one thing per patch, otherwise if one of the different
things you do has a problem, all of the changes have been reverted.

Yeah, it's a pain at times, but that's the way kernel development is,
sorry.

Please break this up into two patches and resend. I will be glad to
queue them up after the merge window ends when 4.16-rc1 is released.

thanks,

greg k-h

2018-02-01 00:59:29

by Yisheng Xie

Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

Hi Greg,

On 2018/1/31 19:32, Greg KH wrote:
> On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
>> ion_page_pool.c now is used to apply pool APIs for system heap, which do
>> not need do any initial at device_initcall.
>>
>> Meanwhile, this patch also remove some useless include files.
>
> Please only do one thing per patch, otherwise if one of the different
> things you do has a problem, all of the changes have been reverted.
>
> Yeah, it's a pain at times, but that's the way kernel development is,
> sorry.

Sorry, I should always remember this.

>
> Please break this up into two patches and resend. I will be glad to
> queue them up after the merge window ends when 4.16-rc1 is released.

I will sent the next version ASAP.

Thanks
Yisheng
>
> thanks,
>
> greg k-h
>
> .
>

2018-02-06 22:52:16

by Laura Abbott

Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

On 01/31/2018 01:50 AM, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
>
> Meanwhile, this patch also remove some useless include files.
>

Acked-by: Laura Abbott <[email protected]>

> Signed-off-by: Yisheng Xie <[email protected]>
> ---
> drivers/staging/android/ion/ion_page_pool.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> index 817849d..3c1eba5 100644
> --- a/drivers/staging/android/ion/ion_page_pool.c
> +++ b/drivers/staging/android/ion/ion_page_pool.c
> @@ -14,12 +14,7 @@
> *
> */
>
> -#include <linux/debugfs.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/err.h>
> -#include <linux/fs.h>
> #include <linux/list.h>
> -#include <linux/init.h>
> #include <linux/slab.h>
> #include <linux/swap.h>
>
> @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
> {
> kfree(pool);
> }
> -
> -static int __init ion_page_pool_init(void)
> -{
> - return 0;
> -}
> -device_initcall(ion_page_pool_init);
>

2018-02-07 00:48:36

by Yisheng Xie

Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

Hi Laura,

On 2018/2/7 6:51, Laura Abbott wrote:
> On 01/31/2018 01:50 AM, Yisheng Xie wrote:
>> ion_page_pool.c now is used to apply pool APIs for system heap, which do
>> not need do any initial at device_initcall.
>>
>> Meanwhile, this patch also remove some useless include files.
>>
>
> Acked-by: Laura Abbott <[email protected]>

Thanks, and I split this into two small patchs as Greg's suggestion in a resent patch.

Yisheng

>
>> Signed-off-by: Yisheng Xie <[email protected]>
>> ---
>> drivers/staging/android/ion/ion_page_pool.c | 11 -----------
>> 1 file changed, 11 deletions(-)
>>
>> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
>> index 817849d..3c1eba5 100644
>> --- a/drivers/staging/android/ion/ion_page_pool.c
>> +++ b/drivers/staging/android/ion/ion_page_pool.c
>> @@ -14,12 +14,7 @@
>> *
>> */
>> -#include <linux/debugfs.h>
>> -#include <linux/dma-mapping.h>
>> -#include <linux/err.h>
>> -#include <linux/fs.h>
>> #include <linux/list.h>
>> -#include <linux/init.h>
>> #include <linux/slab.h>
>> #include <linux/swap.h>
>> @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
>> {
>> kfree(pool);
>> }
>> -
>> -static int __init ion_page_pool_init(void)
>> -{
>> - return 0;
>> -}
>> -device_initcall(ion_page_pool_init);
>>
>
>
> .
>