2023-09-26 21:45:39

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats

On 26.09.2023 06:48, Raghavendra Kakarla wrote:
> Add device node for sleep stats driver which provides various
> low power mode stats.
>
> Cc: [email protected]
> Signed-off-by: Raghavendra Kakarla <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9f4f58e831a4..cee7491de675 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1912,6 +1912,11 @@
> #clock-cells = <0>;
> };
>
> + sram@c3f0000 {
> + compatible = "qcom,rpmh-stats";
> + reg = <0 0x0c3f0000 0 0x400>;
Other nodes (such as the one 5 lines below) use 0x0 instead of
0 to fill out bits 63:32. Please make it consistent.

Konrad
> + };
> +
> spmi_bus: spmi@c440000 {
> compatible = "qcom,spmi-pmic-arb";
> reg = <0x0 0x0c440000 0x0 0x1100>,


2023-09-29 07:54:03

by Raghavendra Kakarla

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats


On 9/27/2023 12:36 AM, Konrad Dybcio wrote:
> On 26.09.2023 06:48, Raghavendra Kakarla wrote:
>> Add device node for sleep stats driver which provides various
>> low power mode stats.
>>
>> Cc: [email protected]
>> Signed-off-by: Raghavendra Kakarla <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 9f4f58e831a4..cee7491de675 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -1912,6 +1912,11 @@
>> #clock-cells = <0>;
>> };
>>
>> + sram@c3f0000 {
>> + compatible = "qcom,rpmh-stats";
>> + reg = <0 0x0c3f0000 0 0x400>;
> Other nodes (such as the one 5 lines below) use 0x0 instead of
> 0 to fill out bits 63:32. Please make it consistent.
Sure, will address this in next patch.
>
> Konrad
>> + };
>> +
>> spmi_bus: spmi@c440000 {
>> compatible = "qcom,spmi-pmic-arb";
>> reg = <0x0 0x0c440000 0x0 0x1100>,