2023-11-22 19:16:13

by Krishna Kurapati PSSNV

Subject: [PATCH 6/6] arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332

For qcs404 and ipq5332, certain interrupts are missing in DT.
Add them to ensure they are in accordance to bindings.

Signed-off-by: Krishna Kurapati <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 8 ++++++--
arch/arm64/boot/dts/qcom/qcs404.dtsi | 16 ++++++++++++++++
2 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 42e2e48b2bc3..79e0c763637f 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -320,8 +320,12 @@ usb: usb@8af8800 {
compatible = "qcom,ipq5332-dwc3", "qcom,dwc3";
reg = <0x08af8800 0x400>;

- interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "hs_phy_irq";
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "dp_hs_phy_irq",
+ "dm_hs_phy_irq",
+ "pwr_event";

clocks = <&gcc GCC_USB0_MASTER_CLK>,
<&gcc GCC_SNOC_USB_CLK>,
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 2721f32dfb71..20a5bc291a43 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -684,6 +684,14 @@ usb3: usb@7678800 {
assigned-clocks = <&gcc GCC_USB20_MOCK_UTMI_CLK>,
<&gcc GCC_USB30_MASTER_CLK>;
assigned-clock-rates = <19200000>, <200000000>;
+
+ interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 319 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hs_phy_irq",
+ "pwr_event",
+ "qusb2_phy";
+
status = "disabled";

usb3_dwc3: usb@7580000 {
@@ -713,6 +721,14 @@ usb2: usb@79b8800 {
assigned-clocks = <&gcc GCC_USB20_MOCK_UTMI_CLK>,
<&gcc GCC_USB_HS_SYSTEM_CLK>;
assigned-clock-rates = <19200000>, <133333333>;
+
+ interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 318 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hs_phy_irq",
+ "pwr_event",
+ "qusb2_phy";
+
status = "disabled";

usb@78c0000 {
--
2.42.0

2023-11-23 07:38:17

by Krzysztof Kozlowski

Subject: Re: [PATCH 6/6] arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332

On 22/11/2023 20:15, Krishna Kurapati wrote:
> For qcs404 and ipq5332, certain interrupts are missing in DT.
> Add them to ensure they are in accordance to bindings.
>
> Signed-off-by: Krishna Kurapati <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 8 ++++++--
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 16 ++++++++++++++++
> 2 files changed, 22 insertions(+), 2 deletions(-)

ERROR: missing [1/6]!
ERROR: missing [2/6]!
ERROR: missing [3/6]!
ERROR: missing [4/6]!
ERROR: missing [5/6]!
✓ [PATCH 6/6] arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332
✓ Signed: DKIM/quicinc.com
+ Link:
https://lore.kernel.org/r/[email protected]
+ Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Total patches: 1
---
WARNING: Thread incomplete!


Fix your threading.

Best regards,
Krzysztof