2022-07-20 11:48:55

by Lukas Bulwahn

Subject: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")
intends to select 'Support for RFC 7919 FFDHE group parameters' for using
FFDHE groups for NVMe In-Band Authentication.

It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended
CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.

Correct the select to the intended config option.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/nvme/target/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
index f0c91f7686a3..79fc64035ee3 100644
--- a/drivers/nvme/target/Kconfig
+++ b/drivers/nvme/target/Kconfig
@@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
select CRYPTO_SHA256
select CRYPTO_SHA512
select CRYPTO_DH
- select CRYPTO_DH_GROUPS_RFC7919
+ select CRYPTO_DH_RFC7919_GROUPS
help
This enables support for NVMe over Fabrics In-band Authentication

--
2.17.1

2022-07-20 11:51:05

by Hannes Reinecke

Subject: Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

On 7/20/22 13:37, Lukas Bulwahn wrote:
> Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")
> intends to select 'Support for RFC 7919 FFDHE group parameters' for using
> FFDHE groups for NVMe In-Band Authentication.
>
> It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended
> CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.
>
> Correct the select to the intended config option.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/nvme/target/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
> index f0c91f7686a3..79fc64035ee3 100644
> --- a/drivers/nvme/target/Kconfig
> +++ b/drivers/nvme/target/Kconfig
> @@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> select CRYPTO_DH
> - select CRYPTO_DH_GROUPS_RFC7919
> + select CRYPTO_DH_RFC7919_GROUPS
> help
> This enables support for NVMe over Fabrics In-band Authentication
>
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes

2022-07-21 05:44:05

by Christoph Hellwig

Subject: Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

Thanks,

applied to nvme-5.20.