2002-08-22 22:31:05

by Randy Hron

[permalink] [raw]
Subject: 2.5.31 qlogic error "this should not happen"

While running bonnie++ with 2.5.31 and 2.5.31-mm1,
a quad xeon with QLogic Corp. QLA2200 (rev 05)
stopped responding. These were the last lines
in /var/log/messages before the box was rebooted.

kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 7d
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 18
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 33
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 33
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 69
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 69
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 4
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 1f
kernel: qlogicfc0 : no handle slots, this should not happen.
kernel: hostdata->queued is 6, in_ptr: 3a

This is the qlogic config:
# CONFIG_SCSI_QLOGIC_FAS is not set
CONFIG_SCSI_QLOGIC_ISP=y
CONFIG_SCSI_QLOGIC_FC=y
# CONFIG_SCSI_QLOGIC_FC_FIRMWARE is not set
# CONFIG_SCSI_QLOGIC_1280 is not set

The same config works fine on 2.4.

Anyone know if the newer qlogic driver compatible with 2.5?
http://marc.theaimsgroup.com/?l=linux-kernel&m=102919565520122&w=2

--
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html


2002-08-22 22:47:21

by Lincoln Dale

[permalink] [raw]
Subject: Re: 2.5.31 qlogic error "this should not happen"


>Anyone know if the newer qlogic driver compatible with 2.5?
>http://marc.theaimsgroup.com/?l=linux-kernel&m=102919565520122&w=2

i forward-ported their (beta) driver to 2.5 and posted the diff to l-k at
the time.


cheers,

lincoln.

2002-08-22 22:50:29

by Doug Ledford

[permalink] [raw]
Subject: Re: 2.5.31 qlogic error "this should not happen"

On Thu, Aug 22, 2002 at 06:39:16PM -0400, [email protected] wrote:
> While running bonnie++ with 2.5.31 and 2.5.31-mm1,
> a quad xeon with QLogic Corp. QLA2200 (rev 05)
> stopped responding. These were the last lines
> in /var/log/messages before the box was rebooted.
>
> kernel: qlogicfc0 : no handle slots, this should not happen.
> kernel: hostdata->queued is 6, in_ptr: 7d

Hmmm...sounds like no one bothered to correct the lock usage in this
driver after the 2.5 kernel switched to per device queue locks instead of
the global io_request_lock usage that this driver depended on to be safe.
Try applying the attached patch and see if it helps you out any.

--
Doug Ledford <[email protected]> 919-754-3700 x44233
Red Hat, Inc.
1801 Varsity Dr.
Raleigh, NC 27606


Attachments:
(No filename) (816.00 B)
linux-2.4.17-iorl_before.patch (1.63 kB)
Download all attachments

2002-08-22 23:04:08

by Eric Weigle

[permalink] [raw]
Subject: Re: 2.5.31 qlogic error "this should not happen"

FWIW-

I occasionally saw that error on our 2.4 RAID system; it went away when I
increased the size of the handles array in qlogicfc.h:

-#define QLOGICFC_REQ_QUEUE_LEN 127 /* must be power of two - 1 */
+#define QLOGICFC_REQ_QUEUE_LEN 255 /* must be power of two - 1 */


I know this probably isn't the ``right'' solution, but it worked for me...
your mileage may vary.

-Eric

--
------------------------------------------------
Eric H. Weigle -- http://public.lanl.gov/ehw/
------------------------------------------------


Attachments:
(No filename) (531.00 B)
(No filename) (232.00 B)
Download all attachments

2002-08-23 00:44:10

by Randy Hron

[permalink] [raw]
Subject: Re: 2.5.31 qlogic error "this should not happen"

> i forward-ported their (beta) driver to 2.5 and posted the diff to l-k at
> the time.

The qlogic (beta) driver is good for 10-20% throughput and lower latency
in the tests I run. I'd love to see the qlogic patch + your
http://marc.theaimsgroup.com/?l=linux-kernel&m=102643109230093&w=2
patch in 2.5.

--
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html

2002-08-23 01:00:03

by Randy Hron

[permalink] [raw]
Subject: Re: 2.5.31 qlogic error "this should not happen"

> Try applying the attached patch and see if it helps you out any.

Thanks Doug. I'm running your patch now. It takes about 8-12 hours
to get past bonnie++. So far, so good.

--
Randy Hron
http://home.earthlink.net/~rwhron/kernel/bigbox.html