David S. Miller wrote:
> It's hash lookup code, nearly identical to ipv4 version except
> it's dealing with 128-bit IP addresses instead of 32-bit.
>
> You give up way too easily, which leads me to belive you'll disappear
> just as easily if complicated bugs stop popping up as a result of your
> changes.
I'll maintain this patch for myself if no one else, so I will not
go away. But, since I am new to this code, and do not have a test
setup to test the ipv6 changes, I was hesitant. I can at the least
patch it how I think it should be and test that ipv4 still works and
it compiles. If you or someone else can do more profound testing on
it, then that would be great.
> The #ifdefs were per request, I personally would like them not to be there
> either. As far as I can tell, the changes are backwards compatible, so there
> should be no need for ifdefs.
>
> I mean put the ifdefs in a header file such as tcp.h, not in the *.c
> code.
Would you object to me just removing all of them and having the patch
unconditionally compiled in?
> I don't require you to test the ipv6 portions, I will be able to
> eyeball them and know if they are right or not, this is how simple
> the ipv6 version of the tcp bits will be.
Ok, I'll work up a patch with the ipv6 support and try to get that
out sometime next week.
Thanks,
Ben
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Ben Greear <[email protected]> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear
From: Ben Greear <[email protected]>
Date: Wed, 18 Sep 2002 19:07:33 -0700
David S. Miller wrote:
> I mean put the ifdefs in a header file such as tcp.h, not in the *.c
> code.
Would you object to me just removing all of them and having the patch
unconditionally compiled in?
Your comments say that SIOCBINDTODEVICE behavior is changed, how can
we legitimately do that all the time without breaking apps?