2002-09-19 15:48:01

by Kent Hunt

Subject: Compile error 2.4.20-pre7 in ip_conntrackt_ftp

FYI

ip_conntrack_ftp.c:440: parse error before
`this_object_must_be_defined_as_export_objs_in_the_Makefile'
ip_conntrack_ftp.c:440: warning: type defaults to
`int' in declaration of
`this_object_must_be_defined_as_export_objs_in_the_Makefile'
ip_conntrack_ftp.c:440: warning: data definition has
no type or storage class

Please CC.

Kent

__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com

2002-09-19 16:18:39

by Adrian Bunk

Subject: Re: Compile error 2.4.20-pre7 in ip_conntrackt_ftp

On Thu, 19 Sep 2002, Kent Hunt wrote:

> FYI
>
> ip_conntrack_ftp.c:440: parse error before
> `this_object_must_be_defined_as_export_objs_in_the_Makefile'
> ip_conntrack_ftp.c:440: warning: type defaults to
> `int' in declaration of
> `this_object_must_be_defined_as_export_objs_in_the_Makefile'
> ip_conntrack_ftp.c:440: warning: data definition has
> no type or storage class

Hi Kent,

thanks for this report. Dave's patch

[NETFILTER]: Backport newnat infrastructure to 2.4.x

removed ip_conntrack_ftp.o from export-objs in net/ipv4/netfilter/Makefile
although there's still an EXPORT_SYMBOL in ip_conntrack_ftp.c
#ifdef CONFIG_IP_NF_NAT_NEEDED. The following (untested) patch should fix
it:


--- net/ipv4/netfilter/Makefile.old 2002-09-19 18:17:31.000000000 +0200
+++ net/ipv4/netfilter/Makefile 2002-09-19 18:17:56.000000000 +0200
@@ -9,7 +9,7 @@

O_TARGET := netfilter.o

-export-objs = ip_conntrack_standalone.o ip_fw_compat.o ip_nat_standalone.o ip_tables.o arp_tables.o
+export-objs = ip_conntrack_standalone.o ip_conntrack_ftp.o ip_fw_compat.o ip_nat_standalone.o ip_tables.o arp_tables.o

# Multipart objects.
list-multi := ip_conntrack.o iptable_nat.o ipfwadm.o ipchains.o

> Please CC.
>
> Kent

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox