2002-12-17 19:56:10

by Sam Ravnborg

Subject: drivers/base/fs/fs.h - needed?

In fs/partitions/check.c the following ugly include exists:
#include <../drivers/base/fs/fs.h> /* Eeeeewwwww */

It can be killed with no problem, the prototypes contained therein are
not used by check.c.

Is this preparations for furter device model changes?
If thats the case, the fs.h file, or at least the content, shall be placed
in include/linux for general access.

Here is a patch to remove the said include statement.

Sam

===== fs/partitions/check.c 1.90 vs edited =====
--- 1.90/fs/partitions/check.c Thu Dec 5 20:01:25 2002
+++ edited/fs/partitions/check.c Tue Dec 17 20:57:02 2002
@@ -19,7 +19,6 @@
#include <linux/blk.h>
#include <linux/kmod.h>
#include <linux/ctype.h>
-#include <../drivers/base/fs/fs.h> /* Eeeeewwwww */

#include "check.h"

2002-12-19 22:10:24

by Patrick Mochel

Subject: Re: drivers/base/fs/fs.h - needed?

On Tue, 17 Dec 2002, Sam Ravnborg wrote:

> In fs/partitions/check.c the following ugly include exists:
> #include <../drivers/base/fs/fs.h> /* Eeeeewwwww */
>
> It can be killed with no problem, the prototypes contained therein are
> not used by check.c.
>
> Is this preparations for furter device model changes?
> If thats the case, the fs.h file, or at least the content, shall be placed
> in include/linux for general access.

It can safely be removed.

Thanks

-pat