2002-12-18 23:36:25

by Adam J. Richter

[permalink] [raw]
Subject: Patch(2.5.52): Add missing PCI ID's for nVidia IDE and PlanB frame grabber

Hi Martin,

This patch adds two pci device id definitions needed to make
a couple of drivers compile in 2.5.52:

drivers/ide/pci/nvidia.c needs PCI_DEVICE_IDE_NVIDIA_NFORCE_IDE
drivers/media/video/planb.c needs PCI_DEVICE_IDE_APPLE_PLANB

If nobody complains, could you please forward these changes to
Linus and confirm to me that you have done this (so I can have a
better idea of what to do if they not appear in 2.5.53)? Thanks in
advance.

--
Adam J. Richter __ ______________ 575 Oroville Road
[email protected] \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."


Attachments:
(No filename) (716.00 B)
pci_ids.diff (827.00 B)
Download all attachments

2002-12-19 00:14:10

by Alan

[permalink] [raw]
Subject: Re: Patch(2.5.52): Add missing PCI ID's for nVidia IDE and PlanB frame grabber

On Wed, 2002-12-18 at 23:35, Adam J. Richter wrote:
> Hi Martin,
>
> This patch adds two pci device id definitions needed to make
> a couple of drivers compile in 2.5.52:
>
> drivers/ide/pci/nvidia.c needs PCI_DEVICE_IDE_NVIDIA_NFORCE_IDE
> drivers/media/video/planb.c needs PCI_DEVICE_IDE_APPLE_PLANB
>
> If nobody complains, could you please forward these changes to
> Linus and confirm to me that you have done this (so I can have a
> better idea of what to do if they not appear in 2.5.53)? Thanks in
> advance.

The NVIDIA one is right, someoen removed it from Linus tree by accident
in 2.5.51 or so when adding other Nvidia bits.


2002-12-19 20:12:15

by Mich Lanners

[permalink] [raw]
Subject: Re: Patch(2.5.52): Add missing PCI ID's for nVidia IDE and PlanB frame grabber

On 19 Dec, this message from Alan Cox echoed through cyberspace:
> On Wed, 2002-12-18 at 23:35, Adam J. Richter wrote:
>> Hi Martin,
>>
>> This patch adds two pci device id definitions needed to make
>> a couple of drivers compile in 2.5.52:
>>
>> drivers/ide/pci/nvidia.c needs PCI_DEVICE_IDE_NVIDIA_NFORCE_IDE
>> drivers/media/video/planb.c needs PCI_DEVICE_IDE_APPLE_PLANB
>>
>> If nobody complains, could you please forward these changes to
>> Linus and confirm to me that you have done this (so I can have a
>> better idea of what to do if they not appear in 2.5.53)? Thanks in
>> advance.
>
> The NVIDIA one is right, someoen removed it from Linus tree by accident
> in 2.5.51 or so when adding other Nvidia bits.

The PLANB one is right as well; it probably never was in there, but is
indeed useful to the driver.

Cheers

Michel

-------------------------------------------------------------------------
Michel Lanners | " Read Philosophy. Study Art.
23, Rue Paul Henkes | Ask Questions. Make Mistakes.
L-1710 Luxembourg |
email [email protected] |
http://www.cpu.lu/~mlan | Learn Always. "