2003-01-07 13:04:11

by Muli Ben-Yehuda

Subject: PATCH: module_text_address() defined but not used in module.h

module_text_address() is defined as 'static int ...' if modules are
not configured in in module.h, leading to a compiler warning that it
is defined but not used. Make it static inline. Patch against
2.5.54-bk.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.975 -> 1.976
# include/linux/module.h 1.35 -> 1.36
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/01/07 [email protected] 1.976
# fix 'defined but not used' warning
# --------------------------------------------
#
diff -Nru a/include/linux/module.h b/include/linux/module.h
--- a/include/linux/module.h Tue Jan 7 14:18:37 2003
+++ b/include/linux/module.h Tue Jan 7 14:18:37 2003
@@ -328,7 +328,7 @@
}

/* Is this address in a module? */
-static int module_text_address(unsigned long addr)
+static inline int module_text_address(unsigned long addr)
{
return 0;
}

--
Muli Ben-Yehuda

my opinions may seem crazy. But they all make sense. Insane sense, but
sense nontheless. -- Shlomi Fish on #offtopic.

2003-01-10 07:25:50

by Rusty Russell

Subject: Re: PATCH: module_text_address() defined but not used in module.h

In message <20030107131243.GJ25540@alhambra> you write:
> module_text_address() is defined as 'static int ...' if modules are
> not configured in in module.h, leading to a compiler warning that it
> is defined but not used. Make it static inline. Patch against
> 2.5.54-bk.

Linus, please apply. Obviously correct, my mistake.

From: Muli Ben-Yehuda <[email protected]>

diff -Nru a/include/linux/module.h b/include/linux/module.h
--- a/include/linux/module.h Tue Jan 7 14:18:37 2003
+++ b/include/linux/module.h Tue Jan 7 14:18:37 2003
@@ -328,7 +328,7 @@
}

/* Is this address in a module? */
-static int module_text_address(unsigned long addr)
+static inline int module_text_address(unsigned long addr)
{
return 0;
}

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.